Page MenuHomePhabricator

ExtensionJsonValidationTest does not support @note
Closed, ResolvedPublic

Description

Mediawiki documentation says:

Extension registration ignores any key in extension.json starting with '@' in the top-level structure or under config, so you can put comments in those parts of the JSON file.

However, if you actually try to put a @note into extension.json, you get this:

1) ExtensionJsonValidationTest::testPassesValidation with data set #21 ('/workspace/src/extensions/Wik...n.json')
Failed asserting that '/workspace/src/extensions/WikibaseCirrusSearch/extension.json did not pass validation.
[] The property @note is not defined and the definition does not allow additional properties
' matches expected false.

/workspace/src/tests/phpunit/structure/ExtensionJsonValidationTest.php:66
/workspace/src/maintenance/doMaintenance.php:94

and the CI build fails. This should be supported by the validator.

Event Timeline

Smalyshev created this task.Feb 8 2019, 7:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2019, 7:49 PM

Change 489308 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/core@master] Make @note and other @-items validate

https://gerrit.wikimedia.org/r/489308

Change 489308 merged by jenkins-bot:
[mediawiki/core@master] registration: Allow @-prefixed keys in manifest_version 2

https://gerrit.wikimedia.org/r/489308

Smalyshev closed this task as Resolved.Feb 14 2019, 6:40 AM
Smalyshev claimed this task.