Page MenuHomePhabricator

When git-submodule clone fails in Quibble, the error should not be ignored
Closed, DuplicatePublic

Description

Failure on an unrelated core patch https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/489356/ https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/8708/console

01:00:48 1) Warning
01:00:48 The data provider specified for ResourcesTest::testFileExistence is invalid.
01:00:48 ResourceLoaderFileModule::readStyleFile: style file not found: "/workspace/src/extensions/Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.inputextender.css"
01:00:48 
01:00:48 /workspace/src/maintenance/doMaintenance.php:94
01:00:48 
01:00:48 2) ResourcesTest::testMissingMessages
01:00:48 Message 'valueview-listrotator-manually' required by 'jquery.ui.listrotator' must exist
01:00:48 Failed asserting that false is true.
01:00:48 
01:00:48 /workspace/src/tests/phpunit/structure/ResourcesTest.php:110
01:00:48 /workspace/src/tests/phpunit/MediaWikiTestCase.php:424
01:00:48 /workspace/src/maintenance/doMaintenance.php:94

Event Timeline

Reedy created this task.Feb 9 2019, 8:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 9 2019, 8:17 AM
Reedy added a subscriber: Krinkle.Feb 9 2019, 8:19 AM

CC @Krinkle as it's possibly related to the flattening he's doing

Thanks @Reedy. From what I can tell, this error would've happened both with and without my change.

The resource is described as being in this directory https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/71d4d863a6ec1f89b8674c9db3290af24376664e/view/lib/wikibase-data-values-value-view, which says:

Submodule link to 488d5b595632487f93f62cc5b35748857ff3e5ce of https://gerrit.wikimedia.org/r/data-values/value-view

That points to https://gerrit.wikimedia.org/r/plugins/gitiles/data-values/value-view/+/488d5b595632487f93f62cc5b35748857ff3e5ce/lib/jquery.ui/, where the file jquery.ui.inputextender.css exists. The error valueview-listrotator-manually similarly, is also a message defined in that same submodule.

These two failures are what I'd expect to happen if the Jenkins job skipped or failed to complete the git submodule update --init command. And the build output confirms this at https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-hhvm-docker/8708/console

+ git submodule update --init --recursive
Submodule 'view/lib/wikibase-api' (https://gerrit.wikimedia.org/r/wikibase/javascript-api) registered for path 'view/lib/wikibase-api'
Submodule 'view/lib/wikibase-data-values-value-view' (https://gerrit.wikimedia.org/r/data-values/value-view) registered for path 'view/lib/wikibase-data-values-value-view'
..
Cloning into 'view/lib/wikibase-api'...
fatal: unable to access 'https://gerrit.wikimedia.org/r/wikibase/javascript-api/': The requested URL returned error: 502
Clone of 'https://gerrit.wikimedia.org/r/wikibase/javascript-api' into submodule path 'view/lib/wikibase-api' failed
..
INFO:backend.MySQL:Starting MySQL
..
INFO:backend.MySQL:Creating the wiki database and grant

So the git-submodule operation failed. And then Quibble skipped over all the other git-submodule operations, and moves on to the next phase (MySQL) as if nothing went wrong.

Instead, Quibble should have failed the build at that point.

Krinkle renamed this task from Wikibase/view/lib/wikibase-data-values-value-view/lib/jquery.ui/jquery.ui.inputextender.css is 404 to When git-submodule clone fails in Quibble, the error should not be ignored.Feb 10 2019, 3:55 AM
Krinkle added a subscriber: hashar.
hashar moved this task from Backlog to Defect on the Quibble board.Mar 18 2019, 2:44 PM
Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMar 18 2019, 2:44 PM
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald TranscriptMar 19 2019, 7:42 AM