Page MenuHomePhabricator
Create Task
Maniphest T215756

Move NavigationTiming configuration values out of startup module
Closed, ResolvedPublic
Actions

Description

The new packageFiles feature allows us to include the configuration variables as a virtual json file inside the module.

Details

SubjectRepoBranchLines +/-
Fix typo in survey sampling factor config keymediawiki/extensions/NavigationTimingmaster+1 -1
Move configuration to packageFiles virtual filemediawiki/extensions/NavigationTimingmaster+80 -66
registration: Define packageFiles for v1 extension schemamediawiki/coremaster+4 -0
Add ability to define packageFiles in extension.jsonmediawiki/coremaster+4 -0
Customize query in gerrit

Event Timeline

• Gilles created this task.Feb 11 2019, 7:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 11 2019, 7:44 AM
• Gilles triaged this task as Medium priority.Feb 11 2019, 7:44 AM
gerritbot subscribed.Feb 11 2019, 7:51 AM

Change 489629 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Move configuration to packageFiles virtual file

https://gerrit.wikimedia.org/r/489629

gerritbot added a project: Patch-For-Review.Feb 11 2019, 7:51 AM
gerritbot added a comment.Feb 11 2019, 9:53 AM

Change 489643 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/core@master] Add ability to define packageFiles in extension.json

https://gerrit.wikimedia.org/r/489643

gerritbot added a comment.Feb 11 2019, 6:27 PM

Change 489643 merged by jenkins-bot:
[mediawiki/core@master] Add ability to define packageFiles in extension.json

https://gerrit.wikimedia.org/r/489643

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 11 2019, 7:00 PM
gerritbot added a comment.Feb 11 2019, 8:39 PM

Change 489782 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/core@master] Define packageFiles for v1 extension schema

https://gerrit.wikimedia.org/r/489782

gerritbot added a comment.Feb 11 2019, 9:05 PM

Change 489782 merged by jenkins-bot:
[mediawiki/core@master] registration: Define packageFiles for v1 extension schema

https://gerrit.wikimedia.org/r/489782

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Feb 11 2019, 9:26 PM
gerritbot added a comment.Feb 13 2019, 6:37 PM

Change 489629 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Move configuration to packageFiles virtual file

https://gerrit.wikimedia.org/r/489629

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.18; 2019-02-19); removed MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 13 2019, 7:00 PM
• Gilles closed this task as Resolved.Feb 14 2019, 9:13 AM
gerritbot added a comment.Feb 18 2019, 10:05 AM

Change 491226 had a related patch set uploaded (by Gilles; owner: Gilles):
[mediawiki/extensions/NavigationTiming@master] Fix typo in survey sampling factor config key

https://gerrit.wikimedia.org/r/491226

gerritbot added a comment.Feb 18 2019, 12:39 PM

Change 491226 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Fix typo in survey sampling factor config key

https://gerrit.wikimedia.org/r/491226

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL