Page MenuHomePhabricator

wikibase: add revision parameter to termbox requests
Closed, ResolvedPublic

Description

  • requests to the termbox service are performed including the revision of the entity to be shown

Details

Related Gerrit Patches:
mediawiki/extensions/Wikibase : mastertermbox: request with revision parameter

Event Timeline

Pablo-WMDE triaged this task as Normal priority.Feb 11 2019, 12:23 PM
Pablo-WMDE created this task.
Pablo-WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-9 board.

Change 491962 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] termbox: request with revision parameter

https://gerrit.wikimedia.org/r/491962

Pablo-WMDE removed Pablo-WMDE as the assignee of this task.Mar 14 2019, 11:05 AM
Pablo-WMDE moved this task from Doing to Peer Review on the Wikidata-Termbox-Iteration-11 board.
Tarrow added a subscriber: Tarrow.Mar 18 2019, 9:40 AM

I think today is the day we start merging this. I'm just rebasing the MediaInfo patch now which has a merge conflict.

My test patch failed: https://integration.wikimedia.org/ci/job/mwext-node10-rundoc-docker/9/console

Jenkins was sad for an unrelated reason. Possibly due to https://phabricator.wikimedia.org/T213944 if it fails again in the same way we might need to investigate this

Change 491962 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] termbox: request with revision parameter

https://gerrit.wikimedia.org/r/491962