Page MenuHomePhabricator
Create Task
Maniphest T215896

Turn referencePreviews into a beta feature
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Andrew-WMDE
Authored By
• Lea_WMDE
Feb 12 2019, 1:20 PM
Tags
Referenced Files
F28294594: LTR.svg
Feb 27 2019, 1:07 PM
F28294595: RTL.svg
Feb 27 2019, 1:07 PM
F28210509: RTL.svg
Feb 13 2019, 5:26 PM
F28210508: LTR.svg
Feb 13 2019, 5:26 PM
F28201302: reference preview beta.png
Feb 12 2019, 1:20 PM
Subscribers
Aklapper
• alexhollender_WMF
gerritbot
JStrodt_WMDE
• Lea_WMDE
WMDE-Fisch

Description

Beta feature explanatory text
Show a preview of a footnote by hovering over its footnote marker.
Please note: In order to use this beta feature, you have to [[Special:Preferences#mw-prefsection-rendering | enable]] [[ https://www.mediawiki.org/wiki/Page_Previews | Page Previews ]].
Please also note: If you’re using the [[w:Wikipedia:Tools/Navigation popups|Navigation popups]] gadget, you won’t see Reference Previews. If you’re using the [[mw:Reference Tooltips|Reference Tooltips]] gadget, both pop-ups from Reference Tooltips and from Reference Previews will appear.

Logo

RTL.svg5 KBDownload

LTR.svg5 KBDownload

Acceptance Criteria

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix shade of blue in beta feature imagesmediawiki/extensions/Popupsmaster+6 -6
Add missing "the"mediawiki/extensions/Popupsmaster+1 -1
Update documentation and signatures of hook handlersmediawiki/extensions/Popupsmaster+21 -10
Add a beta feature switch for reference previewsmediawiki/extensions/Popupsmaster+128 -6
Customize query in gerrit

Event Timeline

• Lea_WMDE created this task.Feb 12 2019, 1:20 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2019, 1:20 PM
• Lea_WMDE triaged this task as Medium priority.Feb 12 2019, 1:23 PM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE set the point value for this task to 3.
• alexhollender_WMF updated the task description. (Show Details)Feb 13 2019, 5:26 PM
• Lea_WMDE moved this task from In preparation to Ready for pickup on the Reference Previews board.Feb 20 2019, 8:42 AM
JStrodt_WMDE updated the task description. (Show Details)Feb 20 2019, 9:48 AM
JStrodt_WMDE subscribed.Feb 20 2019, 10:12 AM
Andrew-WMDE claimed this task.Feb 20 2019, 11:06 AM
JStrodt_WMDE updated the task description. (Show Details)Feb 20 2019, 11:15 AM
thiemowmde added a project: WMDE-QWERTY-Sprint-2019-02-20.Feb 20 2019, 1:16 PM
thiemowmde updated the task description. (Show Details)Feb 20 2019, 1:39 PM
WMDE-Fisch moved this task from Ready for pickup to Doing on the Reference Previews board.Feb 20 2019, 1:53 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-20 board.
gerritbot subscribed.Feb 20 2019, 4:59 PM

Change 491802 had a related patch set uploaded (by Andrew-WMDE; owner: Andrew-WMDE):
[mediawiki/extensions/Popups@master] Add a beta feature switch for reference previews

https://gerrit.wikimedia.org/r/491802

gerritbot added a project: Patch-For-Review.Feb 20 2019, 4:59 PM
Andrew-WMDE moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-02-20 board.Feb 20 2019, 5:37 PM
JStrodt_WMDE updated the task description. (Show Details)Feb 22 2019, 1:17 PM
WMDE-Fisch updated the task description. (Show Details)Feb 22 2019, 2:38 PM
gerritbot added a comment.Feb 25 2019, 11:22 PM

Change 491802 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add a beta feature switch for reference previews

https://gerrit.wikimedia.org/r/491802

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 26 2019, 12:00 AM
thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-02-20 board.Feb 26 2019, 10:08 AM
gerritbot added a comment.Feb 26 2019, 11:17 AM

Change 492999 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Update documentation and signatures of hook handlers

https://gerrit.wikimedia.org/r/492999

gerritbot added a comment.Feb 26 2019, 10:30 PM

Change 492999 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Update documentation and signatures of hook handlers

https://gerrit.wikimedia.org/r/492999

JStrodt_WMDE updated the task description. (Show Details)Feb 27 2019, 12:35 PM
JStrodt_WMDE added a subscriber: WMDE-Fisch.

@WMDE-Fisch Hi Fisch, I just saw that the text for the beta section was slightly changed and because of that, it'is currently missing a "the". I updated the task description accordingly. This is not urgent, but we should fix it eventually.

gerritbot added a comment.Feb 27 2019, 12:47 PM

Change 493219 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Add missing "the"

https://gerrit.wikimedia.org/r/493219

WMDE-Fisch added a comment.Feb 27 2019, 12:50 PM
In T215896#4987775, @JStrodt_WMDE wrote:

@WMDE-Fisch Hi Fisch, I just saw that the text for the beta section was slightly changed and because of that, it'is currently missing a "the". I updated the task description accordingly. This is not urgent, but we should fix it eventually.

Patch is on it's way :-)!

gerritbot added a comment.Feb 27 2019, 12:56 PM

Change 493219 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add missing "the"

https://gerrit.wikimedia.org/r/493219

• alexhollender_WMF updated the task description. (Show Details)Feb 27 2019, 1:07 PM
• alexhollender_WMF subscribed.

FYI I've just updated the svgs in the description (previously they were using the wrong shade of blue).

WMDE-Fisch added a comment.Feb 27 2019, 1:16 PM
In T215896#4987818, @alexhollender wrote:

FYI I've just updated the svgs in the description (previously they were using the wrong shade of blue).

Oh, yeah. Good point. The patch with the "wrong" blue is currently being rolled out on the wikis with the deployment train. I will submit a patch to fix the color but this will then just be deployed next week. I assume we can live with the lighter blue for a week :-) ( and same goes for the missing "the" from earlier )

gerritbot added a comment.Feb 27 2019, 1:20 PM

Change 493225 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Fix shade of blue in beta feature images

https://gerrit.wikimedia.org/r/493225

gerritbot added a comment.Feb 27 2019, 1:30 PM

Change 493225 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix shade of blue in beta feature images

https://gerrit.wikimedia.org/r/493225

• Lea_WMDE closed this task as Resolved.Mar 1 2019, 10:58 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-02-20 board.
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.20; 2019-03-05); removed MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Mar 5 2019, 11:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits