Page MenuHomePhabricator

Edit List does not query using the correct start/end timestamps and displays in UTC
Closed, ResolvedPublic

Description

Issue is twofold:

  • The query fetches edits made from 00:00 to 23:59 of the start/end dates, regardless of what time was set in the event settings.
  • The timestamps shown on the page are in UTC, not the timezone specified for the event.

More context at T206819#4947149

Event Timeline

I looked at the Edit List for a few different events in a few different timezones (including UTC). The revisions listed I either know to be correct or appear to be plausible. For example, https://eventmetrics-dev.wmflabs.org/programs/104/events/243/revisions shows 135 file uploads and 184 total revisions, which I believe is correct from previously querying the database.

The CSV and Wikitext versions of the Edit List for those events also show the same data as the HTML. However, unlike the HTML, they show their times in UTC, rather than the timezone for the event. @MusikAnimal do these need to be changed as well?

Otherwise, I think this is good to go onto Product sign-off.

The CSV and Wikitext versions of the Edit List for those events also show the same data as the HTML. However, unlike the HTML, they show their times in UTC, rather than the timezone for the event. MusikAnimal do these need to be changed as well?

Yes indeed! PR at https://github.com/wikimedia/eventmetrics/pull/184

Looked at the CSV and Wikitext versions of a couple of different events in different timezones. The dates of the first and last revisions match those in the HTML Edit List.

It looks like such a small change that I don't think there is much more to test. Moving toe Product sign-off.