Hook 'EditFilterMerged' should be called after 'force edit summary' preference is enforced
Open, LowPublic

Description

See e.g. [http://de.wikipedia.org/w/index.php?title=Spezial:Missbrauchsfilter-Logbuch&wpSearchFilter=4]: There is a log entry
:"2009-06-16T21:30:44: 90.136.148.123 [...] triggered filter 4, performing the action "edit" on [[:de:Stempeltechnik]]. Actions taken: none; [...]".
Although rule #4 does not disallow changes (it just logs them), you can't see the change of [[:de:Stempeltechnik]], when you have a look at [[:de:special:contributions/90.136.148.123]]. So what happened there? I gave some more of these examples at [http://en.wikipedia.org/wiki/User_talk:Werdna/Archive_1#63364096679].


Version: 1.16.x
Severity: normal

Details

Reference
bz19605
bzimport set Reference to bz19605.
bzimport added a subscriber: Unknown Object (MLST).
seth created this task.Jul 8 2009, 9:28 PM
  • Bug 19680 has been marked as a duplicate of this bug. ***

Prodego wrote:

When a user is given a warning they must click save a second time in order to save the edit. If they don't do this, the edit is not saved, so nothing will happen.

(batch change)

Minor bugs that nevertheless need looking into

seth added a comment.Jul 16 2009, 10:21 PM

(In reply to comment #2)

of course, i know that. the rule i'm talking about does not give a warning and does not disallow edits, it just should log them.

For some reason the check for 'force edit summary' is after the hook that AbuseFilter uses.

This option is on by default on de.wikipedia.org — so I'll bet that's what happened.

Unassigning from me, adding some CCs to get wider feedback on whether it should be moved.

werdna removed a subscriber: werdna.Dec 10 2014, 6:16 PM

Add Comment