Page MenuHomePhabricator
Create Task
Maniphest T216102

Determine which PHP version to target with Parsoid
Closed, ResolvedPublic
Actions

Description

What should the minimum supported version be?

There are two considerations:

  • Soonish, Parsoid will be set up as a PHP service in the Wikimedia cluster, so obviously it needs to support whatever version of PHP we intend to use there.
  • Maybe less soonish, Parsoid will become a part of the MediaWiki distribution (at the latest after the parser unification, but possibly even in its semi-standalone form), so it should probably support all PHP versions that MediaWiki supports.

Current WMF migration plan is T176370: Migrate to PHP 7 in WMF production - HHVM to PHP 7.2 by 2018-19 Q2 (I guess the timeline in the task description is outdated?). The task for dropping third-party support for HHVM is T176370: Migrate to PHP 7 in WMF production which is unclear about whether that's supposed to happen immediately after the WMF switch of later. I don't think there's anything in Phabricator about plans for dropping 7.x support for some x.

Per the PHP support schedule, 7.0 is end-of-life with no security support; 7.1 is end-of-life and security support will be dropped next December.

Details

SubjectRepoBranchLines +/-
Bump minimum PHP version to 7.2mediawiki/services/parsoidmaster+1 -1
Stop running php7.1 checks on Parsoidintegration/configmaster+0 -2
Upgrade minimum PHP version to 7.1 to let us use nullable typesmediawiki/services/parsoidmaster+4 -3
Customize query in gerrit

Related Objects

Event Timeline

Tgr created this task.Feb 14 2019, 4:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2019, 4:38 AM
gerritbot subscribed.Feb 14 2019, 4:39 AM

Change 486835 had a related patch set uploaded (by Gergő Tisza; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] Upgrade minimum PHP version to 7.1 to let us use nullable types

https://gerrit.wikimedia.org/r/486835

gerritbot added a project: Patch-For-Review.Feb 14 2019, 4:39 AM
ssastry subscribed.Feb 14 2019, 4:46 AM

Our initial work here is not to set up a service ... Parsoid will become a composer library that will be pulled into core and made accessible via integration code in core. Initially, it won't replace the PHP parser, but we aim to bridge and fix all output and feature gaps and make it the default which has a longer timeline. But, basically, it won't be a standalone service. This detail doesn't change the larger question about PHP versions though.

Joe subscribed.Feb 14 2019, 3:22 PM

@ssastry you should aim at php 7.x support, with x >= 2.

Production is currently on 7.2 and when we migrate to debian buster later in the year we'll probably migrate to PHP 7.3.

ssastry added a comment.Feb 14 2019, 3:23 PM
In T216102#4954452, @Joe wrote:

@ssastry you should aim at php 7.x support, with x >= 2.

Production is currently on 7.2 and when we migrate to debian buster later in the year we'll probably migrate to PHP 7.3.

Thanks .. that is great.

Anomie subscribed.Feb 14 2019, 4:45 PM

Maybe less soonish, Parsoid will become a part of the MediaWiki distribution (at the latest after the parser unification, but possibly even in its semi-standalone form), so it should probably support all PHP versions that MediaWiki supports.

T192166: Drop HHVM support from MediaWiki is the task for dropping the requirement for working with HHVM 3.18 (and hhvm.php7.all = false).

I don't see a task in Phabricator for dropping support for PHP 7.0 or 7.1, but I expect that would probably happen along with T192166 since Wikimedia will be using 7.2 or 7.3.

Jdforrester-WMF subscribed.Feb 14 2019, 6:57 PM

I've created T216165: Drop PHP 7.0 support from MediaWiki (and T216166: Drop PHP 7.1 support from MediaWiki) for the wider work.

Stashbot subscribed.Feb 14 2019, 8:50 PM

Mentioned in SAL (#wikimedia-releng) [2019-02-14T20:50:57Z] <Krinkle> Reloading Zuul to deploy https://gerrit.wikimedia.org/r/490528 / T216102

gerritbot added a comment.Feb 14 2019, 11:36 PM

Change 486835 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Upgrade minimum PHP version to 7.1 to let us use nullable types

https://gerrit.wikimedia.org/r/486835

ssastry moved this task from Backlog to Deployment on the Parsoid-PHP board.Mar 2 2019, 3:39 PM
cscott subscribed.Mar 6 2019, 6:17 PM

We should probably bump Parsoid to 7.2 since (a) the zest port is using 7.2 and (b) mediawiki is planning to skip 7.1 anyway.

gerritbot added a comment.Mar 6 2019, 6:24 PM

Change 494802 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[integration/config@master] Stop running php7.1 checks on Parsoid

https://gerrit.wikimedia.org/r/494802

gerritbot added a comment.Mar 6 2019, 7:20 PM

Change 494810 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Bump minimum PHP version to 7.2

https://gerrit.wikimedia.org/r/494810

ssastry triaged this task as High priority.Mar 13 2019, 2:54 AM
gerritbot added a comment.Mar 19 2019, 4:39 PM

Change 494802 had a related patch set uploaded (by Reedy; owner: C. Scott Ananian):
[integration/config@master] Stop running php7.1 checks on Parsoid

https://gerrit.wikimedia.org/r/494802

gerritbot added a comment.Mar 19 2019, 4:55 PM

Change 494802 merged by jenkins-bot:
[integration/config@master] Stop running php7.1 checks on Parsoid

https://gerrit.wikimedia.org/r/494802

gerritbot added a comment.Mar 19 2019, 5:07 PM

Change 494810 had a related patch set uploaded (by C. Scott Ananian; owner: C. Scott Ananian):
[mediawiki/services/parsoid@master] Bump minimum PHP version to 7.2

https://gerrit.wikimedia.org/r/494810

gerritbot added a comment.Mar 19 2019, 5:55 PM

Change 494810 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Bump minimum PHP version to 7.2

https://gerrit.wikimedia.org/r/494810

ssastry mentioned this in T213493: Install PHP7 on scandium.Mar 21 2019, 2:14 PM
ssastry closed this task as Resolved.Mar 23 2019, 2:18 PM
ssastry claimed this task.

We are targeting 7.2

Aklapper removed a project: Patch-For-Review.Apr 10 2020, 9:43 AM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL