Page MenuHomePhabricator
Create Task
Maniphest T216123

Tag is not added when new page is created through External Guidance
Closed, ResolvedPublic
Actions

Description

Accessing the translation of "Bearded dragon" from Simple English to Indonesian, it is possible to follow the contribution path to start a new article (since it does not exist for Indonesian).

When creating the new page for it (changing the page name to use the user namespace as a test space), no specific tag is present in the history view to indicate that it came from an automatic translation as it would be expected (T212405, T209132).

We need to make sure that the corresponding tag is added when the user contributes.

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2019, 11:25 AM
Pginer-WMF triaged this task as High priority.Feb 14 2019, 11:25 AM
santhosh assigned this task to KartikMistry.Feb 14 2019, 12:15 PM
santhosh added a subscriber: KartikMistry.

Need to add our tag to a valid list of tags for VE $wgWMEEditCampaigns as per T209132. Also to CX

@KartikMistry Please note.

gerritbot added a subscriber: gerritbot.Feb 26 2019, 1:24 PM

Change 493021 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[mediawiki/extensions/ContentTranslation@master] Add edittag for ExternalGuidance

https://gerrit.wikimedia.org/r/493021

santhosh added a comment.Feb 27 2019, 6:27 AM

The patches will look like as follows in mediawiki-config/wmf-config/InitialSettings.php:

'wmgContentTranslationCampaigns' => [
	'default' => [
		'article-recommender-1' => true,
		'cx2outreach' => true,
		'cxstats' => true,
		'newarticle' => true,
		'specialcx' => true,
		'staff-recommender' => true,
                'external-machine-translation' => [
			"edittag" =>  "external-machine-translation"
    	        ],

The keys in this configuration are campaign values and the value of edittag is the actual edit tag we will add for the campaign

For VE

wmgWMEEditCampaigns = [ 'external-machine-translation' ];
gerritbot added a comment.Feb 27 2019, 7:03 AM

Change 493155 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/mediawiki-config@master] Enable edittag for ExternalGuidance in CX and VE

https://gerrit.wikimedia.org/r/493155

gerritbot added a comment.Feb 27 2019, 7:03 AM

Change 493021 abandoned by KartikMistry:
Add edittag for ExternalGuidance

Reason:
Not needed.

https://gerrit.wikimedia.org/r/493021

• chelsyx added a subscriber: • chelsyx.Mar 2 2019, 4:37 AM

Hi @Pginer-WMF , I think we also need tags when users edit an existing page in their local language, or when they edit the original page in English. Hopefully this fix them all.

gerritbot added a comment.Mar 5 2019, 12:05 PM

Change 493155 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable edittag for ExternalGuidance in CX and VE

https://gerrit.wikimedia.org/r/493155

gerritbot added a comment.Mar 5 2019, 12:40 PM

Change 494477 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/mediawiki-config@master] Enable edittag for ExternalGuidance in CX and VE

https://gerrit.wikimedia.org/r/494477

gerritbot added a comment.Mar 7 2019, 12:02 PM

Change 494477 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable edittag for ExternalGuidance in CX and VE

https://gerrit.wikimedia.org/r/494477

Stashbot added a subscriber: Stashbot.Mar 7 2019, 12:08 PM

Mentioned in SAL (#wikimedia-operations) [2019-03-07T12:08:21Z] <kartik@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:494477]] Enable edittag for ExternalGuidance in CX and VE (T216123) (duration: 00m 57s)

KartikMistry moved this task from In Review to Done on the ExternalGuidance board.Mar 7 2019, 12:09 PM
Pginer-WMF added a comment.EditedMar 8 2019, 1:28 PM

Results for the following cases:

Desktop:

New article using Content translation on desktop: the tag is added, as expected.

New article using Visual Editor: tag not added, issue captured in T217892: Starting a new page from scratch does not lead directly to Visual Editor, causing the result not to be tagged

Editing existing article: the tag is added, as expected.

Mobile:
Creating new article: the tag is added, as expected.

Editing existing article: the tag is added, as expected.

The tag seems correctly configured, the only issue getting it the way for the tag to be applied seems T217892. So I think we can close this ticket and continue the work in that follow-up ticket

Pginer-WMF closed this task as Resolved.Mar 8 2019, 1:28 PM
gerritbot added a comment.Mar 12 2019, 8:51 AM

Change 495842 had a related patch set uploaded (by KartikMistry; owner: KartikMistry):
[operations/mediawiki-config@master] Add 'campaign' prefix for EG tag

https://gerrit.wikimedia.org/r/495842

gerritbot added a comment.Mar 12 2019, 11:04 AM

Change 495842 merged by jenkins-bot:
[operations/mediawiki-config@master] Add 'campaign' prefix for EG tag

https://gerrit.wikimedia.org/r/495842

Stashbot added a comment.Mar 12 2019, 11:11 AM

Mentioned in SAL (#wikimedia-operations) [2019-03-12T11:11:59Z] <kartik@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:495842]] Add campaign prefix for EG tag (T216123) (duration: 00m 49s)

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL