Implement length limit for schema text
Closed, ResolvedPublic
Actions

Description

Configurable, defaults to 50 000 bytes for now. Consider how to inform the user if the limit is exceeded.

Details

Subject	Repo	Branch	Lines +/-
Tell the user that more info about errors is available	mediawiki/extensions/WikibaseSchema	master	+7 -0
Implement length limit for schema text	mediawiki/extensions/WikibaseSchema	master	+84 -6
Refactor so method does one thing only	mediawiki/extensions/WikibaseSchema	master	+21 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T214904 [Story] length limits for Schema inputs
		Resolved		Michael	T216148 Implement length limit for schema text

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 14 2019, 2:57 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Ready to pick up on the EntitySchema board.Feb 14 2019, 3:02 PM

Michael edited projects, added Shape Expressions Sprint 4; removed EntitySchema.Mar 12 2019, 2:04 PM

Michael claimed this task.Mar 13 2019, 10:24 AM

Michael moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.

Restricted Application added a project: User-Michael. · View Herald TranscriptMar 13 2019, 10:24 AM

Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.Mar 13 2019, 10:24 AM

Change 496153 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Refactor so method does one thing only

https://gerrit.wikimedia.org/r/496153

Change 496154 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Implement length limit for schema text

https://gerrit.wikimedia.org/r/496154

Change 496153 merged by Michael Große:
[mediawiki/extensions/WikibaseSchema@master] Refactor so method does one thing only

https://gerrit.wikimedia.org/r/496153

Change 496154 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Implement length limit for schema text

https://gerrit.wikimedia.org/r/496154

Lucas_Werkmeister_WMDE moved this task from Doing to Verification on the Shape Expressions Sprint 4 board.Mar 14 2019, 10:47 AM

Michael moved this task from ⏳ In progress to ✅ my work done on the User-Michael board.Mar 14 2019, 11:27 AM

I tested it by copying a long Wikipedia article in the field :D
I got two different warnings: "There are problems with some of your input." before the input field and the length error message below the field.
It would be great to have the first message to say "There are problems with some of your input. Please check the error message below."

Also we should follow the OOUI guidelines for errors https://phabricator.wikimedia.org/M241

Michael removed Michael as the assignee of this task.Mar 18 2019, 10:49 AM

Michael moved this task from ✅ my work done to 💬 waiting on other's work or feedback on the User-Michael board.

Michael subscribed.

In T216148#5031783, @Lea_Lacroix_WMDE wrote:

I tested it by copying a long Wikipedia article in the field :D
I got two different warnings: "There are problems with some of your input." before the input field and the length error message below the field.
It would be great to have the first message to say "There are problems with some of your input. Please check the error message below."

That message is currently hard-coded in mediawiki core: https://github.com/wikimedia/mediawiki/blob/5612194879bd4f5c7d3e7c75d42b08bf91b84428/includes/htmlform/HTMLForm.php#L612

In T216148#5031783, @Lea_Lacroix_WMDE wrote:

Also we should follow the OOUI guidelines for errors https://phabricator.wikimedia.org/M241

We are currently using the form error message from mediawiki core. But we could add our own styles on this page to adjust their styles. 🤔

@Lea_Lacroix_WMDE @Lydia_Pintscher would you be ok with opening a new ticket for these style adjustments? That would allow us to discuss and estimate them separately from the functionality itself.

PS: also compare the current design in Wikibase https://test.wikidata.org/wiki/Special:SetLabelDescriptionAliases/Q123/

In T216148#5032248, @Michael wrote:

In T216148#5031783, @Lea_Lacroix_WMDE wrote:

I tested it by copying a long Wikipedia article in the field :D
I got two different warnings: "There are problems with some of your input." before the input field and the length error message below the field.
It would be great to have the first message to say "There are problems with some of your input. Please check the error message below."

That message is currently hard-coded in mediawiki core: https://github.com/wikimedia/mediawiki/blob/5612194879bd4f5c7d3e7c75d42b08bf91b84428/includes/htmlform/HTMLForm.php#L612

After looking into this some more, this turned out to be easier than expected!

Change 497332 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Tell the user that more info about errors is available

https://gerrit.wikimedia.org/r/497332

Change 497332 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Tell the user that more info about errors is available

https://gerrit.wikimedia.org/r/497332

Michael moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.Mar 19 2019, 2:45 PM

Change 497332 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Tell the user that more info about errors is available

https://gerrit.wikimedia.org/r/497332

Michael moved this task from Peer Review to Verification on the Shape Expressions Sprint 4 board.Mar 20 2019, 8:42 AM