Page MenuHomePhabricator
Create Task
Maniphest T216191

Replace Istanbul with nyc
Closed, ResolvedPublic
Actions

Description

The istanbul package that we've been using for code coverage reporting has been deprecated and replaced with nyc. We need to eliminate the use of a deprecated package and replace it with a new one

Details

ProjectBranchLines +/-Subject
mediawiki/services/eventstreamsmaster+16 -8Replace Istanbul with nyc
mediawiki/services/graphoidmaster+23 -11Replace Istanbul with nyc
mediawiki/services/citoidmaster+68 -19Citoid: Fixed invalid peer deps
mediawiki/services/mathoidmaster+13 -9Replace Istanbul with nyc
mediawiki/services/chromium-rendermaster+4 -3Replace istanbul with nyc
mediawiki/services/mobileappsmaster+3 -2Replace istanbul with nyc
mediawiki/services/recommendation-apimaster+114 -126Replace istanbul with nyc
Customize query in gerrit

Related Objects

Event Timeline

• Pchelolo created this task.Feb 14 2019, 10:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 14 2019, 10:22 PM
• Mholloway updated the task description. (Show Details)Feb 14 2019, 10:26 PM

Removed the linked patch next to mobileapps, which was unrelated unless I'm missing something.

• Pchelolo added a comment.Feb 14 2019, 10:27 PM
In T216191#4955874, @Mholloway wrote:

Removed the linked patch next to mobileapps, which was unrelated unless I'm missing something.

Yup, that's yet another depreciation of a tool we were using throughout our projects :(

• Pchelolo updated the task description. (Show Details)Feb 15 2019, 12:26 AM
• mobrovac updated the task description. (Show Details)Feb 16 2019, 1:49 AM
EvanProdromou moved this task from Not a real column to Doing on the Platform Team Workboards board.Feb 19 2019, 3:23 PM
EvanProdromou edited projects, added Platform Team Workboards (Doing); removed Platform Team Workboards.
gerritbot added a subscriber: gerritbot.Feb 22 2019, 5:49 PM

Change 492357 had a related patch set uploaded (by Bmansurov; owner: Bmansurov):
[mediawiki/services/recommendation-api@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492357

gerritbot added a project: Patch-For-Review.Feb 22 2019, 5:49 PM
bmansurov mentioned this in rMSRAa2a4e9c89eed: Replace istanbul with nyc.Feb 22 2019, 5:52 PM
bmansurov mentioned this in rMSRA12680e9e3e81: Replace istanbul with nyc.
bmansurov mentioned this in rMSRAc5e269a74ffa: Replace istanbul with nyc.Feb 22 2019, 6:05 PM
bmansurov mentioned this in rMSRA48dffd3912b6: Replace istanbul with nyc.Feb 22 2019, 6:47 PM
gerritbot added a comment.Feb 22 2019, 7:15 PM

Change 492357 merged by jenkins-bot:
[mediawiki/services/recommendation-api@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492357

• Pchelolo updated the task description. (Show Details)Feb 22 2019, 7:16 PM
gerritbot added a comment.Feb 25 2019, 11:30 PM

Change 492929 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/services/mobileapps@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492929

gerritbot added a comment.Feb 25 2019, 11:36 PM

Change 492929 merged by Ppchelko:
[mediawiki/services/mobileapps@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492929

gerritbot added a comment.Feb 25 2019, 11:38 PM

Change 492930 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/services/chromium-render@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492930

• Mholloway updated the task description. (Show Details)Feb 25 2019, 11:40 PM
• Mholloway mentioned this in rMSCRa1dba4faad7e: Replace istanbul with nyc.Feb 25 2019, 11:43 PM
gerritbot added a comment.Feb 25 2019, 11:44 PM

Change 492930 merged by Ppchelko:
[mediawiki/services/chromium-render@master] Replace istanbul with nyc

https://gerrit.wikimedia.org/r/492930

gerritbot added a comment.Mar 6 2019, 1:00 PM

Change 494709 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/services/mathoid@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/494709

gerritbot added a comment.Mar 11 2019, 7:31 PM

Change 494709 merged by jenkins-bot:
[mediawiki/services/mathoid@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/494709

• mobrovac updated the task description. (Show Details)Mar 11 2019, 8:11 PM
gerritbot added a comment.Mar 15 2019, 9:10 PM

Change 496878 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/services/citoid@master] Citoid: Fixed invalid peer deps

https://gerrit.wikimedia.org/r/496878

• mobrovac updated the task description. (Show Details)Mar 15 2019, 9:14 PM
gerritbot added a comment.Mar 15 2019, 9:15 PM

Change 496878 merged by jenkins-bot:
[mediawiki/services/citoid@master] Citoid: Fixed invalid peer deps

https://gerrit.wikimedia.org/r/496878

• mobrovac triaged this task as Medium priority.Mar 19 2019, 3:51 PM
• mobrovac updated the task description. (Show Details)
• mobrovac updated the task description. (Show Details)
• mobrovac edited projects, added Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)); removed Patch-For-Review.
• mobrovac edited projects, added Services (doing); removed Services (next).
• holger.knust updated the task description. (Show Details)Jun 5 2019, 6:18 PM
• holger.knust updated the task description. (Show Details)Jun 5 2019, 7:04 PM
gerritbot added a comment.Jun 5 2019, 7:51 PM

Change 514565 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/services/cxserver@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/514565

gerritbot added a project: Patch-For-Review.Jun 5 2019, 7:51 PM
• holger.knust updated the task description. (Show Details)Jun 5 2019, 8:54 PM
• holger.knust updated the task description. (Show Details)Jun 6 2019, 6:02 PM
• holger.knust updated the task description. (Show Details)Jun 6 2019, 6:31 PM
• holger.knust updated the task description. (Show Details)Jun 6 2019, 7:11 PM
gerritbot added a comment.Jun 8 2019, 12:57 AM

Change 515283 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/services/eventstreams@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/515283

gerritbot added a comment.Jun 9 2019, 8:46 PM

Change 516060 had a related patch set uploaded (by Holger Knust; owner: Holger Knust):
[mediawiki/services/graphoid@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/516060

• holger.knust updated the task description. (Show Details)Jun 9 2019, 8:52 PM
• holger.knust updated the task description. (Show Details)Jun 10 2019, 12:51 AM
• holger.knust updated the task description. (Show Details)Jun 10 2019, 12:57 AM
gerritbot added a comment.Jun 10 2019, 6:07 AM

Change 516060 merged by Ppchelko:
[mediawiki/services/graphoid@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/516060

gerritbot added a comment.Jun 10 2019, 7:05 AM

Change 515283 merged by Ppchelko:
[mediawiki/services/eventstreams@master] Replace Istanbul with nyc

https://gerrit.wikimedia.org/r/515283

• Pchelolo closed this task as Resolved.Jun 10 2019, 7:05 AM
• Pchelolo claimed this task.
• Pchelolo updated the task description. (Show Details)
• Pchelolo edited projects, added Services (done), Platform Team Workboards (Done with CPT); removed Patch-For-Review, Services (doing), Platform Team Workboards (Doing).

I'm sure we've forgot something, but it's ok, the remaining will be replaced as it goes.

Physikerwelt mentioned this in T309077: Remove dependency on istanbul in Mathoid.May 27 2022, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL