- Mentioned In
- rGSVT0f93d5212b44: Only enable Upload button when there are changes
rGSVTabda521fa78d: Only enable Upload button when there are changes
rGSVT2247f79699d3: Only enable Upload button when there are changes
rGSVT2819d13cdf1d: [WIP] Only enable Upload button when there are changes
T220618: [BUG] TypeError: appConfig.translations[a][o.getValue(...)] is undefined
The file is getting uploading to commons after pressing ENTER key without complete translation. The file gets uploaded to commons as soon as the ENTER key is pressed after filling first translated word.
When I first visit the tool (or after refreshing the page), the "Upload to Commons" but is enabled. I can click it and I get:
500: Internal Server Error The upload is an exact duplicate of the current version of [[:File:Osmotic pressure on blood cells 20190220211300.svg]].
When entering or removing text, I find a 1-2 second delay before the state of "Upload to commons" is updated. This gives me a window in which I can upload a duplicate image, giving the same error as T216209#5107613.
This is unless I change focus, in which case the state us updated immediately.
A few more observations/potential bugs:
- Sometimes, if I have an unsaved translation, after logging in I cannot upload the translation to Commons (even after reloading the page or switching translation languages back and forth). I have seen this happen on FF60, FF66, Chromium 57.
- After successfully uploading a translation to Commons, I sometimes cannot upload a modified translation of the same language. I have seen this on FF60, FF66 and Chromium 57.
I have found can only get around the above two problems reliably by doing a hard refresh on the browser.
- If I switch to a translation which already exists in the SVG, without modifying it I can upload to Commons.
I will caveat the above by saying that the behaviour I am seeing does not always happen reliably. Sometimes, when I repeat the same action under the same conditions (as far as I can tell) I can get a different outcome. There may also be slight differences between browsers/browser versions.
@dom_walden Just making sure it's clear this is still in the QA column. No rush to get to it! I felt it was a semi-risky change, which is why I left it here. It looks like it's been deployed already and we haven't received any complaints, so maybe I didn't break anything :)
As for T216209#5140591, if those are still happening, I think they might be unrelated and deserving of separate tickets.