Page MenuHomePhabricator

Make "make primary" work in read mode
Closed, ResolvedPublic

Description

"make primary" is available in read mode (and, when clicked, transforms into "primary"), but the change is not submitted until the form is edited and submitted.
Should clicking "make primary" immediately submit an API call in read mode? Probably?

Related Objects

Event Timeline

matthiasmullie triaged this task as High priority.

I'd have thought it should only say "Primary" and not be a link in read mode

@PDrouin-WMF @Ramsey-WMF thoughts?

It's less a link and more a button. Users should be able to mark a statement primary in read mode: https://wikimedia.invisionapp.com/d/main/#/console/15638944/324827163/preview

Hmm ... you sure? Everything else requires the user to press 'publish'. Don't you think it'd be a bit odd for 'make primary' to be different?

To me it'd make most sense for the form to go into 'edit' mode once the user changes the state of one of primary - and then they can click 'publish' or 'cancel'

Yeah, the original concepts allowed for that, but I think your solution
works, Cormac (going into edit mode once the user changes the primary state
and clicking publish or cancel).

Change 491298 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, and make state changes impossible during submit

https://gerrit.wikimedia.org/r/491298

@matthiasmullie this task is in the to-do column, but has a patch-for-review tag. Should we move it to "doing"?

Change 491298 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Toggle edit mode on primary, and make state changes impossible during submit

https://gerrit.wikimedia.org/r/491298

Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.Mar 8 2019, 4:48 PM
Ramsey-WMF closed this task as Resolved.Apr 24 2019, 1:59 AM

Old ticket. The current setup on production (make prominent switches to edit mode and needs a "Publish Changes" click to finish the process) is correct per agreed upon spec.