- Mentioned In
- T237618: Amendments to the Gerrit Privilege policy
T217866: Provide access to iOS engineers for iOS group
- Mentioned Here
- T218686: Create Gerrit Administrator right policy
T199385: Develop a workflow to recommend / propose developers who should have +2 rights in Gerrit
T200322: Creation of new mediawiki/extensions/** group in gerrit
T191741: Bundle Replace Text extension with MW 1.31
TechCom hosted discussion on this RFC on January 23rd.
From the talk page:
Putting that aside, the section on merging without code review feels particularly prescriptive; however, it makes the point towards the end:
For extensions (and other projects) not deployed to the Wikimedia cluster, the code review policy is up to the maintainer or author of the extension.
I think I would prefer if that were easier to glean from an inspectional reading of the policy rather than a close reading.
IMO that's a good point and should be addressed.
A special case that should maybe be adressed: Are there special policies for extensions that are not deployed by Wikimedia, but bundled with MediaWiki? T191741: Bundle Replace Text extension with MW 1.31 provides an example for this, where self-merges are forbidden as part of the process. (T191741#4179808)
I just want to thank TechCom and all of the contributors to the discussion for the deep consideration put into these revisions of the Gerrit privilege policy. Moving forward with these revisions will make our code healthier and more secure, and I greatly appreciate the well-documented code review guidelines that cover security, coding conventions, unit testing, localization, optimization and debugging considerations. Thank you!
Will this also touch / update T199385: Develop a workflow to recommend / propose developers who should have +2 rights in Gerrit and/or supersede T200322: Creation of new mediawiki/extensions/** group in gerrit?
I think this should be explicitly announced on wikitech-l, and not just buried in a techcom update
In particular, automatic +2 for WMDE seems like a big change (I'm not opposed, just saying its a big change).
What's left to do in this task, apart from answering T216295#4995706 ?
Slightly related: T218686: Create Gerrit Administrator right policy
This has happened in https://lists.wikimedia.org/pipermail/wikitech-l/2019-March/091683.html
The page now lives at https://www.mediawiki.org/wiki/Gerrit/Privilege_policy.
I believe @Aklapper questions were answered on Wikitech, but not 100% sure. Will ask Tim in today's meeting to confirm and to close accordingly.