Page MenuHomePhabricator

Special:Log/translationreview: allow filtering by different actions
Closed, ResolvedPublicFeature

Description

Similarly to what happens with most MediaWiki logs, please allow filtering the log entries of the translation review log by the type of action performed. Currently they seem to be: change the state of translations and review of translations. Thanks.

Event Timeline

Nikerabbit changed the subtype of this task from "Task" to "Feature Request".Jan 5 2021, 1:30 PM
Nikerabbit added a project: good first task.
Nikerabbit subscribed.

This should be as simple as adding ActionFilteredLogs item to extension.json and adding corresponding i18n messages to en.json and qqq.json. See https://www.mediawiki.org/wiki/Manual:$wgActionFilteredLogs for docs.

rETRA utils/TranslateLogFormatter.php is using $type = $this->entry->getFullType();. A quick codesearch search indicates this extension is the only one using this. As far as I can see, all others are using $type = $this->entry->getSubtype(); so they can later configure the ActionFilteredLogs properly in extension.json. However Translate seems to use rETRA TranslateHooks.php to do this for other logs. I find this a bit messy to me, and I don't think this is a good first task as tagged. I'm quite confused.

There is already entry in TranslateHooks for $wgActionFilteredLogs which can be updated for this log type. The reason it is using PHP instead of extension.json is that the whole page translation feature can be disabled with a config option.

Change 810311 had a related patch set uploaded (by MarcoAurelio; author: MarcoAurelio):

[mediawiki/extensions/Translate@master] Allow filtering the translation review log by subtypes of actions

https://gerrit.wikimedia.org/r/810311

There is already entry in TranslateHooks for $wgActionFilteredLogs which can be updated for this log type. The reason it is using PHP instead of extension.json is that the whole page translation feature can be disabled with a config option.

Thanks for the hint. Where would you prefer this configured then? extension.json or TranslateHooks.php? It seems more natural to me to do it in extension.json as the log type and handler for this specific log is configured over there.

In extension.json, because it is not specific to page translation feature.

In extension.json, because it is not specific to page translation feature.

Thank you. I'll amend the patch.

MarcoAurelio changed the task status from Open to In Progress.Jul 2 2022, 10:47 AM
MarcoAurelio moved this task from working on to ready/patched/SWAT on the User-MarcoAurelio board.

Change 810311 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Allow filtering the translation review log by subtypes of actions

https://gerrit.wikimedia.org/r/810311

abi_ triaged this task as Medium priority.Jul 4 2022, 8:50 AM

Change 811281 had a related patch set uploaded (by MarcoAurelio; author: MarcoAurelio):

[mediawiki/extensions/Translate@master] log-action-filter-translationreview: Add missing colon

https://gerrit.wikimedia.org/r/811281

Change 811281 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] log-action-filter-translationreview: Add missing colon

https://gerrit.wikimedia.org/r/811281

MarcoAurelio changed the task status from In Progress to Open.EditedJul 8 2022, 12:24 PM

Patches merged, changed status to open just in case further QA/reviews are needed by the Language Team.

abi_ subscribed.

Tested on MediaWiki