Page MenuHomePhabricator
Create Task
Maniphest T216369

Adding a caption add file unintentionally to watchlist
Closed, ResolvedPublic
Actions

Description

Adding a caption add file unintentionally to watchlist

Steps to reproduce:

  1. Enable, if not already done, the option "Add pages I create and files I upload to my watchlist" in your preferences (watchlist section)
  2. Load a file without captions
  3. Add a caption in a language of your choice
  4. Result: File was added to your watchlist even that you have not created the file/file page

Expected result: No change of the watchlist status.

My interpretation of this behaviour: Creating a first caption is handled as page creation. And this is wrong.

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/WikibaseMediaInfomaster+77 -0Add integration test for watchlist behavior
mediawiki/extensions/Wikibasemaster+18 -4Fix watching new entities on existing pages
Customize query in gerrit

Event Timeline

Raymond created this task.Feb 17 2019, 6:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2019, 6:00 PM
Jdforrester-WMF added a project: SDC General.Feb 19 2019, 12:02 PM
Jdforrester-WMF added a subscriber: Jdforrester-WMF.

Probably a bug in the slot handling code in EditPage (such as it is), but we'd need to check this out at our end first.

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 19 2019, 12:02 PM
• Addshore added a subscriber: • Addshore.Feb 19 2019, 4:26 PM

This will be due to the adding of a caption creating the mediainfo entity

in Wikibase, MediawikiEditEntity::getWatchDefault does not take into account slots creation vs page creation when using the "watchcreations" user pref.
It probably should now?

Yann added a subscriber: Yann.Apr 28 2019, 5:36 PM
• Ramsey-WMF assigned this task to Cparle.May 2 2019, 12:14 AM
• Ramsey-WMF triaged this task as Medium priority.
• Ramsey-WMF added projects: Structured Data Engineering, Structured-Data-Team-Current-Work.
• Ramsey-WMF added a subscriber: • Ramsey-WMF.

following up on this: problem is still present as of today (may or may not have been fixed previously)

Restricted Application added a project: Multimedia. · View Herald TranscriptMay 2 2019, 12:14 AM
• Ramsey-WMF moved this task from Untriaged to Next up on the Multimedia board.May 2 2019, 1:01 AM
Roy17 added a subscriber: Roy17.May 15 2019, 6:24 PM

Adding depicts statements also adds pages to my watchlist even though I've switched that off for pages I edit in settings.

seav added a subscriber: seav.Jun 13 2019, 7:40 PM
Cparle removed Cparle as the assignee of this task.Jun 17 2019, 9:16 AM
Cparle added a subscriber: Cparle.
• Ramsey-WMF removed a project: Structured-Data-Team-Current-Work.Aug 8 2019, 6:01 PM
Aklapper edited projects, added Structured-Data-Backlog; removed Multimedia.Aug 10 2019, 11:55 PM
LucasWerkmeister added a subscriber: LucasWerkmeister.Sep 1 2019, 1:53 PM

At least for statements, this issue is still present – I just got a bunch of new watchlist entries from some AC/DC edits.

Zhangj1079 added a subscriber: Zhangj1079.Sep 22 2019, 2:23 AM
Marsupium added a subscriber: Marsupium.Sep 30 2019, 3:14 PM
Masumrezarock100 added a subscriber: Masumrezarock100.Oct 31 2019, 11:16 PM
Roy17 awarded a token.Dec 16 2019, 5:33 PM
Ainali added a subscriber: Ainali.Feb 14 2020, 8:28 PM
• Sarahmarie1981 edited projects, added WMDE-Tech-Communication-Source-Code-Berlin; removed Structured-Data-Backlog.Mar 16 2020, 3:38 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptMar 16 2020, 3:38 PM
Aklapper removed a project: WMDE-Tech-Communication-Source-Code-Berlin.Mar 16 2020, 4:02 PM
Raymond added a comment.Jun 5 2020, 5:27 AM

Any progress on it? It is really annoying to remove watchlist entries again after using AC/DC

gerritbot added a comment.Jun 5 2020, 10:25 PM

Change 602777 had a related patch set uploaded (by Lucas Werkmeister; owner: Lucas Werkmeister):
[mediawiki/extensions/Wikibase@master] Fix watching new entities on existing pages

https://gerrit.wikimedia.org/r/602777

gerritbot added a project: Patch-For-Review.Jun 5 2020, 10:25 PM

Change 602778 had a related patch set uploaded (by Lucas Werkmeister; owner: Lucas Werkmeister):
[mediawiki/extensions/WikibaseMediaInfo@master] Add integration test for watchlist behavior

https://gerrit.wikimedia.org/r/602778

LucasWerkmeister claimed this task.EditedJun 5 2020, 10:26 PM
LucasWerkmeister added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).

Alright, I think I’ve found a fix for this. Adding the Wikidata campsite board for review, because the fix is actually in Wikibase, not WikibaseMediaInfo. (That said, review from the WikibaseMediaInfo people would help as well, especially for the integration test.)

LucasWerkmeister moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 5 2020, 10:27 PM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jun 5 2020, 11:15 PM
gerritbot added a comment.Jun 5 2020, 11:35 PM

Change 602777 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix watching new entities on existing pages

https://gerrit.wikimedia.org/r/602777

gerritbot added a comment.Jun 5 2020, 11:37 PM

Change 602778 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Add integration test for watchlist behavior

https://gerrit.wikimedia.org/r/602778

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.36; 2020-06-09).Jun 6 2020, 12:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jun 6 2020, 12:10 AM
LucasWerkmeister moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jun 6 2020, 12:28 AM
Lydia_Pintscher closed this task as Resolved.Jun 16 2020, 4:27 PM
Lydia_Pintscher moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Lydia_Pintscher added a subscriber: Lydia_Pintscher.

Tested it and it works for me now \o/

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL