Page MenuHomePhabricator

Allow AND/OR searching for multiple hashtags
Closed, ResolvedPublic

Description

The tool supports searching for multiple hashtags, by entering e.g. HashtagA, HashtagB in the search box. The default behaviour as implemented is for this to return edits which contain either HashtagA or HashtagB. There are times, however, when a user might want to return results that contain HashtagA and HashtagB.

This could be implemented via a kind of Advanced Search dropdown. I wouldn't want to complicate the initially presented interface too much.

Event Timeline

Samwalton9 triaged this task as Normal priority.Feb 18 2019, 11:03 AM
Samwalton9 created this task.

@Samwalton9 I am working on this. I will submit a PR soon.

AdityaJ added a comment.EditedFeb 23 2019, 4:39 AM

@Samwalton9 I have opened a pull request for this. It would be great if you could review it.

https://github.com/Samwalton9/hashtags/pull/25

Samwalton9 moved this task from Features to Doing on the Hashtags board.

@Samwalton9 I have updated the PR. Also, I am thinking of writing a test for it once the changes are approved. :)