Page MenuHomePhabricator
Create Task
Maniphest T216406

Rename `Image-reviewer` to `image-reviewer`, then migrate all its members
Closed, ResolvedPublic
Actions

Description

Image-reviewer is a user group used in Wikimedia Commons and fawiki. User groups are all defined in lowercase in code. We should

  1. rename the group where it is used in InitialiseSettings.php and elsewhere in wmf-config.
  2. rename the keys to use lowercases in WikimediaMessages / cherry-pick and merge to the current wmf branch(es).
  3. migrate existing members using the migrateUserGroups.php maintenance script

This needs to be done all in the same SWAT window to avoid issues so I'll need some time to find the appropriate time to do it right.

Details

SubjectRepoBranchLines +/-
Rename Image-reviewer to image-reviewer on fawikioperations/mediawiki-configmaster+3 -3
Delete Image-reviewer group from commonswiki for goodoperations/mediawiki-configmaster+6 -0
Delete Image-reviewer group from commonswiki for goodoperations/mediawiki-configmaster+3 -0
Regrant image-reviewers@commonswiki mass-upload rightoperations/mediawiki-configmaster+1 -0
Rename `Image-reviewer` to `image-reviewer` for Commonsoperations/mediawiki-configmaster+7 -9
Disallow admins to grant or remove image reviewer groupoperations/mediawiki-configmaster+0 -3
Create image-reviewer for commonswiki with same rights as Image-revieweroperations/mediawiki-configmaster+5 -0
Rename `Image-reviewer` to `image-reviewer`mediawiki/extensions/WikimediaMessageswmf/1.34.0-wmf.11+301 -301
Keep both image-reviewer and Image-reviewermediawiki/extensions/WikimediaMessagesmaster+699 -397
Rename `Image-reviewer` to `image-reviewer`mediawiki/extensions/WikimediaMessagesmaster+302 -302
Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
MarcoAurelio triaged this task as Low priority.Feb 18 2019, 12:41 PM
Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptFeb 18 2019, 12:41 PM
MarcoAurelio moved this task from unsorted/backlog to later/stalled/blocked on the User-MarcoAurelio board.Feb 19 2019, 11:20 AM
Framawiki subscribed.Feb 20 2019, 6:10 PM
Framawiki moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.Mar 10 2019, 10:36 AM
gerritbot added a comment.Jul 2 2019, 4:59 PM

Change 520274 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikimediaMessages@master] Rename Image-reviewer to image-reviewer

https://gerrit.wikimedia.org/r/520274

gerritbot added a project: Patch-For-Review.Jul 2 2019, 4:59 PM
gerritbot added a comment.Jul 2 2019, 5:40 PM

Change 520283 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Rename Image-reviewer to image-reviewer

https://gerrit.wikimedia.org/r/520283

gerritbot added a comment.Jul 2 2019, 5:44 PM

Change 520285 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikimediaMessages@wmf/1.34.0-wmf.11] Rename Image-reviewer to image-reviewer

https://gerrit.wikimedia.org/r/520285

Urbanecm claimed this task.Jul 2 2019, 5:51 PM
Urbanecm moved this task from Config - to process to To deploy on the Wikimedia-Site-requests board.
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJul 2 2019, 5:51 PM
Urbanecm moved this task from Backlog to To deploy - scheduled for SWAT on the User-Urbanecm board.Jul 2 2019, 5:52 PM
gerritbot added a comment.Jul 2 2019, 6:00 PM

Change 520274 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Rename Image-reviewer to image-reviewer

https://gerrit.wikimedia.org/r/520274

MarcoAurelio added a comment.EditedJul 2 2019, 6:00 PM

According to this query, AbuseFilters # 70, 180 and 192 would need their syntax to use image-reviewer instead of Image-reviewer.

@Billinghurst or @Jdforrester-PERSONAL : as a commons administrator, would you be able to alter those filters to support, for now, both Image-reviewer and image-reviewer? The first can be removed once this process is finished.

Thanks.

MarcoAurelio added a subscriber: Billinghurst.Jul 2 2019, 6:02 PM
MarcoAurelio added a subscriber: Jdforrester-WMF.
MarcoAurelio added a subscriber: Jdforrester-PERSONAL.Jul 2 2019, 6:07 PM
Jdforrester-PERSONAL added a comment.Jul 2 2019, 6:07 PM

Sure, looking now.

Jdforrester-PERSONAL added a comment.Jul 2 2019, 6:13 PM

All three migrated to support both image-reviewer and Image-reviewer (but note that #70 adds a tag that we'll probably want to rename too?). Should we fix filter #182 too, even though it's disabled?

MarcoAurelio added a comment.Jul 2 2019, 6:15 PM
In T216406#5301300, @Jdforrester-PERSONAL wrote:

All three migrated to support both image-reviewer and Image-reviewer

Thanks!

(but note that #70 adds a tag that we'll probably want to rename too?).

I think we can do it. Maybe tomorrow?

Should we fix filter #182 too, even though it's disabled?

Why not? :)

gerritbot added a comment.Jul 2 2019, 6:27 PM

Change 520291 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/WikimediaMessages@master] Keep both image-reviewer and Image-reviewer

https://gerrit.wikimedia.org/r/520291

gerritbot added a comment.Jul 2 2019, 7:29 PM

Change 520291 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Keep both image-reviewer and Image-reviewer

https://gerrit.wikimedia.org/r/520291

Urbanecm moved this task from To deploy - scheduled for SWAT to Analytics/Under discussion on the User-Urbanecm board.Jul 2 2019, 11:11 PM
gerritbot added a comment.Jul 3 2019, 9:26 PM

Change 520285 abandoned by Urbanecm:
Rename Image-reviewer to image-reviewer

Reason:
no longer necessary

https://gerrit.wikimedia.org/r/520285

Urbanecm moved this task from To deploy to Working on on the Wikimedia-Site-requests board.Jul 8 2019, 4:27 PM
Urbanecm moved this task from Analytics/Under discussion to To deploy - scheduled for SWAT on the User-Urbanecm board.Jul 14 2019, 9:11 PM
Urbanecm moved this task from Working on to To deploy on the Wikimedia-Site-requests board.

The WikimediaMessages were successfully deployed by the train. As such, there should be no blocker to deploy this. I've scheduled this for tomorrow EU SWAT.

gerritbot added a comment.Jul 14 2019, 10:15 PM

Change 523006 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Create image-reviewer for commonswiki with same rights as Image-reviewer

https://gerrit.wikimedia.org/r/523006

Urbanecm updated the task description. (Show Details)Jul 14 2019, 10:22 PM
Urbanecm moved this task from To deploy to Working on on the Wikimedia-Site-requests board.Jul 14 2019, 10:33 PM
In T216406#5331460, @Urbanecm wrote:

The WikimediaMessages were successfully deployed by the train. As such, there should be no blocker to deploy this. I've scheduled this for tomorrow EU SWAT.

Unfortunately, I've found a blocker. https://commons.wikimedia.org/wiki/MediaWiki:Grouppage-image-reviewer needs to be created with same content as https://commons.wikimedia.org/wiki/MediaWiki:Grouppage-Image-reviewer, otherwise, the link on Special:UserGroupRights will break.

Urbanecm moved this task from To deploy - scheduled for SWAT to Blocked on others on the User-Urbanecm board.Jul 14 2019, 10:34 PM
Urbanecm moved this task from Blocked on others to To deploy - scheduled for SWAT on the User-Urbanecm board.Jul 15 2019, 10:50 AM
Urbanecm moved this task from Working on to To deploy on the Wikimedia-Site-requests board.
gerritbot added a comment.Jul 15 2019, 11:02 AM

Change 523006 merged by jenkins-bot:
[operations/mediawiki-config@master] Create image-reviewer for commonswiki with same rights as Image-reviewer

https://gerrit.wikimedia.org/r/523006

Stashbot added a comment.Jul 15 2019, 11:08 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:08:27Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: SWAT: [[:gerrit:523006|Create image-reviewer for commonswiki with same rights as Image-reviewer]] (T216406) (duration: 00m 52s)

Stashbot added a comment.Jul 15 2019, 11:11 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:11:04Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Disallow admins to grant or revoke image reviewer due to migration (T216406) (duration: 00m 50s)

gerritbot added a comment.Jul 15 2019, 11:11 AM

Change 523137 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Disallow admins to grant or remove image reviewer group

https://gerrit.wikimedia.org/r/523137

gerritbot added a comment.Jul 15 2019, 11:13 AM

Change 523137 merged by jenkins-bot:
[operations/mediawiki-config@master] Disallow admins to grant or remove image reviewer group

https://gerrit.wikimedia.org/r/523137

Stashbot added a comment.Jul 15 2019, 11:13 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:13:24Z] <Urbanecm> Running mwscript migrateUserGroup.php --wiki=commonswiki Image-reviewer image-reviewer for T216406

gerritbot added a comment.Jul 15 2019, 11:42 AM

Change 520283 merged by jenkins-bot:
[operations/mediawiki-config@master] Rename Image-reviewer to image-reviewer for Commons

https://gerrit.wikimedia.org/r/520283

Stashbot added a comment.Jul 15 2019, 11:48 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:48:37Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: SWAT: [[:gerrit:520283|Rename Image-reviewer to image-reviewer for Commons]] (1/2, T216406) (duration: 00m 50s)

Stashbot added a comment.Jul 15 2019, 11:49 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:49:43Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[:gerrit:520283|Rename Image-reviewer to image-reviewer for Commons]] (2/2, T216406) (duration: 00m 48s)

Stashbot added a comment.Jul 15 2019, 11:52 AM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T11:52:39Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Regrant image reviewers on commonswiki the ability to mass upload (T216406) (duration: 00m 50s)

gerritbot added a comment.Jul 15 2019, 11:53 AM

Change 523143 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Regrant image-reviewers@commonswiki mass-upload right

https://gerrit.wikimedia.org/r/523143

gerritbot added a comment.Jul 15 2019, 11:53 AM

Change 523143 merged by Urbanecm:
[operations/mediawiki-config@master] Regrant image-reviewers@commonswiki mass-upload right

https://gerrit.wikimedia.org/r/523143

Urbanecm added a comment.Jul 15 2019, 11:55 AM

Almost everything went well. For some reason, the Image-reviewer group is still in commonswiki, with just mass-upload right. Going to investigate that...

Urbanecm moved this task from To deploy - scheduled for SWAT to Working on on the User-Urbanecm board.Jul 15 2019, 11:57 AM
Stashbot added a comment.Jul 15 2019, 12:00 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T12:00:24Z] <Urbanecm> Running mwscript initSiteStats.php --wiki=commonswiki --update to update Special:Statistics after a big change (T216406)

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 12:11 PM
gerritbot added a comment.Jul 15 2019, 12:32 PM

Change 523151 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Delete Image-reviewer group from commonswiki for good

https://gerrit.wikimedia.org/r/523151

gerritbot added a project: Patch-For-Review.Jul 15 2019, 12:32 PM

Change 523151 merged by jenkins-bot:
[operations/mediawiki-config@master] Delete Image-reviewer group from commonswiki for good

https://gerrit.wikimedia.org/r/523151

gerritbot added a comment.Jul 15 2019, 12:50 PM

Change 523157 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Delete Image-reviewer group from commonswiki for good

https://gerrit.wikimedia.org/r/523157

gerritbot added a comment.Jul 15 2019, 12:52 PM

Change 523157 merged by jenkins-bot:
[operations/mediawiki-config@master] Delete Image-reviewer group from commonswiki for good

https://gerrit.wikimedia.org/r/523157

Stashbot added a comment.Jul 15 2019, 12:52 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-15T12:52:55Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: Delete Image-reviewer group from commonswiki for good (T216406) (duration: 00m 51s)

Urbanecm added a comment.Jul 15 2019, 12:55 PM
In T216406#5332733, @Urbanecm wrote:

Almost everything went well. For some reason, the Image-reviewer group is still in commonswiki, with just mass-upload right. Going to investigate that...

The group is defined in UploadWizard's extension.json. I've unset that group in operations/mediawiki-config, but to resolve T216405: Cannot update to grunt-banana-checker on WikimediaMessages due to some keys containing uppercases, we'd need to solve it inside extension.json directly. Honestly, I don't think we should create that group in the extension at all. @MarcoAurelio, opinions?

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 1:10 PM
MarcoAurelio added a comment.Jul 15 2019, 3:44 PM

Thanks for moving this forward and having it done. I agree. I'd file a task against UploadWizard and ask them to rename the Image-reviewer permission in extension.json -or- remove it from the file. I don't know which option would be better.

Urbanecm added a comment.Jul 15 2019, 3:52 PM

Filled as T228073: Remove Image-reviewer group from extension.json.

Stashbot added a comment.Jul 15 2019, 4:04 PM

Mentioned in SAL (#wikimedia-releng) [2019-07-15T16:04:07Z] <Urbanecm> Run urbanecm@deployment-deploy01:~$ mwscript migrateUserGroup.php --wiki=commonswiki Image-reviewer image-reviewer (T216406)

Urbanecm moved this task from Working on to Analytics/Under discussion on the User-Urbanecm board.Jul 15 2019, 5:21 PM
Urbanecm added a comment.Jul 22 2019, 9:12 PM

@MarcoAurelio Ping me once you're ready to do this for the next wiki!

Urbanecm reassigned this task from Urbanecm to MarcoAurelio.Jul 22 2019, 11:57 PM
Urbanecm moved this task from To deploy to Working on on the Wikimedia-Site-requests board.
Urbanecm subscribed.

Reassign to me once this is ready.

MarcoAurelio added a comment.Jul 23 2019, 12:35 PM

@Urbanecm What do you have in mind?

Urbanecm added a comment.Jul 23 2019, 9:59 PM
In T216406#5356907, @MarcoAurelio wrote:

@Urbanecm What do you have in mind?

I don't know, you told me that we should do commonswiki, and then the other wiki (fawiki?). I thought you want to check something/do some prep or whatever :-).

gerritbot added a comment.Jul 29 2019, 6:13 PM

Change 526196 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Rename Image-reviewer to image-reviewer on fawiki

https://gerrit.wikimedia.org/r/526196

gerritbot added a project: Patch-For-Review.Jul 29 2019, 6:13 PM
Urbanecm claimed this task.Jul 29 2019, 6:14 PM

Seems there is nothing necessary, abuse filters looks sane, processing then.

gerritbot added a comment.Jul 29 2019, 6:18 PM

Change 526196 merged by jenkins-bot:
[operations/mediawiki-config@master] Rename Image-reviewer to image-reviewer on fawiki

https://gerrit.wikimedia.org/r/526196

Stashbot added a comment.Jul 29 2019, 6:19 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-29T18:19:50Z] <Urbanecm> Run mwscript migrateUserGroup.php --wiki=fawiki Image-reviewer image-reviewer (T216406)

Stashbot added a comment.Jul 29 2019, 6:21 PM

Mentioned in SAL (#wikimedia-operations) [2019-07-29T18:21:55Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[:gerrit:526196|Rename Image-reviewer to image-reviewer on fawiki]] (T216406) (duration: 00m 47s)

Urbanecm closed this task as Resolved.Jul 29 2019, 6:22 PM

Image-reviewer is gone everywhere! The messages for the capital version still exists through, but I don't think removing them falls into this task.

Maintenance_bot removed a project: Patch-For-Review.Jul 29 2019, 7:10 PM
MarcoAurelio moved this task from later/stalled/blocked to cabinet on the User-MarcoAurelio board.Jul 30 2019, 2:37 PM
MarcoAurelio added a comment.Jul 31 2019, 11:17 AM

Thanks @Urbanecm :-)

I'll ask translatewiki.net people to remove the uppercase messages from the WikimediaMessages repo, now that they're unused, so we can move forward (unless you know how to do it; I don't know how to mass remove from many files).

MarcoAurelio moved this task from Backlog to Closed on the WikimediaMessages board.Nov 13 2019, 11:51 AM
MarcoAurelio added a parent task: T229396: Remove `Image-reviewer` keys from WikimediaMessages.Apr 6 2023, 11:12 PM
MarcoAurelio removed a parent task: T216405: Cannot update to grunt-banana-checker on WikimediaMessages due to some keys containing uppercases.
Restricted Application added a subscriber: Huji. · View Herald TranscriptApr 6 2023, 11:13 PM
gerritbot added a comment.Apr 7 2023, 12:27 PM

Change 906724 had a related patch set uploaded (by MarcoAurelio; author: MarcoAurelio):

[mediawiki/extensions/WikimediaMessages@master] Remove 'Image-reviewer' messages

https://gerrit.wikimedia.org/r/906724

gerritbot added a project: Patch-For-Review.Apr 7 2023, 12:27 PM
MarcoAurelio removed a project: Patch-For-Review.Apr 8 2023, 11:22 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL