Page MenuHomePhabricator
Create Task
Maniphest T216420

[EPIC] Display core version of history page
Closed, ResolvedPublic
Actions

Description

User story

As an experienced editor, I would like to be able to access the entire functionality of the history page from my mobile device so that I can perform my work on mobile

Acceptance criteria

  • all desktop functionality (with tentative exceptions TBD) will be available on mobile
  • diffs will navigate to the mobile diff page (rather than the desktop diff)

Most recent mockups

history list items (1).png (2×1 px, 1018 KB)

Notes from hackathon

POC: https://gerrit.wikimedia.org/r/#/q/topic:kiwi

Open questions

Action items

  • follow up on ad hoc date analysis for history page - some smaller things remaining, most highly trafficked links are covered https://phabricator.wikimedia.org/T214935
  • Discuss undo workflow
  • Review the history page as an admin

Details

SubjectRepoBranchLines +/-
Drop History override on mobilemediawiki/extensions/MobileFrontendmaster+0 -302
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versionsmediawiki/extensions/MobileFrontendmaster+103 -1 K
DRY up rev link generation in History and Contributionsmediawiki/coremaster+34 -29
Consistently use classes for deleted items in lists of diffsmediawiki/coremaster+3 -3
Separate time and date in Changeslist'smediawiki/coremaster+12 -3
Customize query in gerrit

Related Objects
Search...

Event Timeline

ovasileva triaged this task as Medium priority.Feb 18 2019, 4:28 PM
ovasileva created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 18 2019, 4:28 PM
ovasileva moved this task from Backlog to EPICS on the Advanced Mobile Contributions board.Feb 18 2019, 4:28 PM
Jdlrobson added a parent task: T210168: [EPIC] Get rid of MobileFrontend's special pages for changes list where equivalents exist in core.Feb 21 2019, 6:31 PM
Jdlrobson added a subtask: T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.
Jdlrobson added a project: MobileFrontend (MobileFrontend Special Pages).
Jdlrobson moved this task from Backlog to History on the MobileFrontend (MobileFrontend Special Pages) board.
Jdlrobson updated the task description. (Show Details)Feb 26 2019, 1:07 AM
Jdlrobson added a subtask: T217902: SpecialMobileHistory doesn't respect dir=prev.Mar 12 2019, 3:45 PM
gerritbot added a comment.Mar 26 2019, 4:35 PM

Change 499240 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Consistently use classes for deleted items in lists of diffs

https://gerrit.wikimedia.org/r/499240

gerritbot added a project: Patch-For-Review.Mar 26 2019, 4:35 PM
Jdlrobson added a subtask: T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs.Mar 26 2019, 5:07 PM
gerritbot added a comment.Mar 26 2019, 5:38 PM

Change 499265 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Separate time from date in history page timestamp

https://gerrit.wikimedia.org/r/499265

gerritbot added a comment.Mar 26 2019, 5:53 PM

Change 499268 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] POC: History page is styled consistently with Special:MobileHistory

https://gerrit.wikimedia.org/r/499268

gerritbot added a comment.Mar 26 2019, 11:41 PM

Change 499240 merged by jenkins-bot:
[mediawiki/core@master] Consistently use classes for deleted items in lists of diffs

https://gerrit.wikimedia.org/r/499240

gerritbot added a comment.Mar 26 2019, 11:45 PM

Change 499336 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Separate time and date in Changeslist's

https://gerrit.wikimedia.org/r/499336

gerritbot added a comment.Mar 26 2019, 11:46 PM

Change 499336 abandoned by Jdlrobson:
Separate time and date in Changeslist's

Reason:
The current page on mobile doesn't support i18n. The core one does. Separating these, would break that i18n since 2019-03-26T23:42:20 is a user preferered format.

The downside of not doing this, is additional noise to the mobile interface with repeated information but I will talk to Alex about how that might be consolidated.

https://gerrit.wikimedia.org/r/499336

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.24; 2019-04-02).Mar 27 2019, 12:01 AM
Jdlrobson closed subtask T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements as Resolved.Mar 27 2019, 1:03 AM
• Tbayer subscribed.Mar 28 2019, 6:49 PM
gerritbot added a comment.Mar 28 2019, 6:56 PM

Change 499864 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Remove the SpecialMobile(History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

gerritbot added a comment.Mar 29 2019, 12:12 AM

Change 499265 merged by jenkins-bot:
[mediawiki/core@master] DRY up rev link generation in History and Contributions

https://gerrit.wikimedia.org/r/499265

ovasileva raised the priority of this task from Medium to High.Apr 2 2019, 10:44 AM
ovasileva added a project: Web-Team-Backlog.
ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson moved this task from Needs Prioritization to Readers-Web-Kanbanana-Board-2018-19-Q4 on the Web-Team-Backlog board.Apr 2 2019, 4:00 PM
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4); removed Web-Team-Backlog.
Jdlrobson moved this task from To Do to Quarterly Goals on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4) board.
• alexhollender_WMF added subscribers: Jdrewniak, • alexhollender_WMF.Apr 2 2019, 4:07 PM

I'm not sure how helpful this will be, but here is some additional CSS I added to the History page (building off the CSS @Jdrewniak wrote at the offsite hackathon), in order to get it to display like the screenshot in the description

input.mw-history-compareselectedversions-button {
	width: 100%;
	height: 50px;
	-webkit-appearance: unset;
	background: #3366cc;
	color: white;
	font-size: 18px;
	font-weight: 600;
	position: -webkit-sticky;
	top: 1px;
}

ul#pagehistory {
	padding: 0;
	list-style: none;
	margin-left: 0;
}

#pagehistory li {
	border-bottom: 1px solid #d4d4d4;
	padding: 0.5em 0;
	margin: 0;
}

#pagehistory li.selected {
	margin-top: 6px;
}

span.mw-history-histlinks {
	float: right;
}

#pagehistory li input[type=radio] {
	float: left;
	margin-right: 10px;
	border: 1px solid #3366cc;
	background: #3366cc;
	transform: sale(1.2);
}

#pagehistory li input[type=radio] {
	margin: 6px 12px 0 0;
}

#pagehistory li input[type=radio]:nth-child(3) {
	margin-right: 15px;
}

#pagehistory li.before input[name='oldid'], #pagehistory li.after input[name='diff'] {
	visibility: initial;
	opacity: 0.15;
}

#pagehistory li.selected {
	border: none;
	background: #eaecf0;
}

#pagehistory .history-user,
#pagehistory .comment,
#pagehistory .mw-tag-markers,
#pagehistory .mw-history-tools,
#pagehistory .mw-changeslist-separator {
	display: block;
	margin-left: 57px;
}

#pagehistory .history-size{
	margin-left: 54px;
}

#pagehistory .mw-changeslist-separator,
#pagehistory abbr {
	display: none;
}
gerritbot added a comment.Apr 4 2019, 11:37 PM

Change 499864 abandoned by Jdlrobson:
Remove the SpecialMobile(Watchlist|History|Contributions) page and use the core versions

https://gerrit.wikimedia.org/r/499864

gerritbot added a comment.Apr 4 2019, 11:39 PM

Change 501449 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop History override on mobile

https://gerrit.wikimedia.org/r/501449

ovasileva closed subtask T219874: It should be possible to view the desktop history page in AMC as Resolved.Apr 9 2019, 11:19 AM
ovasileva removed a subtask: T219895: Style the history page for AMC users.Jun 4 2019, 9:33 AM
ovasileva closed subtask T224970: Deploy new history page to AMC users as Resolved.Jun 11 2019, 1:24 PM
ovasileva removed a subtask: T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.Jul 2 2019, 9:35 PM
ovasileva removed a subtask: T219349: Incorporate better visual layout of contributions page on Minerva, inspired by old design.
ovasileva removed a subtask: T217902: SpecialMobileHistory doesn't respect dir=prev.
ovasileva closed this task as Resolved.Jul 2 2019, 9:38 PM
ovasileva claimed this task.
ovasileva removed a subtask: T217197: Move skin "subtitle" markup that contains redirect and breadcrumbs.
Jdlrobson added a subtask: T205581: History, Special:Contributions, Special:RecentChanges, Special:Watchlist should be fully skinnable - use pseudo elements for separating elements.Jul 3 2019, 5:39 PM
gerritbot added a comment.Dec 18 2019, 12:12 AM

Change 501449 abandoned by Jdlrobson:
Drop History override on mobile

Reason:
Not enough resources/focus to work on this right now.

https://gerrit.wikimedia.org/r/501449

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptDec 18 2019, 12:12 AM
Jdlrobson mentioned this in T345768: Remove skin specific history page styles for Minerva.Oct 20 2023, 12:48 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL