Page MenuHomePhabricator

Exclude redirects for all metrics
Closed, ResolvedPublic1 Estimated Story Points

Description

See T206817#4965342

We don't care about redirects, and they shouldn't be counted toward pages created/improved, or anywhere else in the application.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Merged and ready for QA. The example event we use in the integration tests includes some redirects, see https://github.com/wikimedia/eventmetrics/blob/master/src/AppBundle/DataFixtures/ORM/extended.yml#L11-L51 for the details. Hopefully that code is decipherable.

dom_walden added a subscriber: dom_walden.

Comparing production with dev I see that moved pages no longer appear in the revisions/edit list nor are counted in the stats.

For example, https://eventmetrics-dev.wmflabs.org/programs/119/events/267, where user had moved two pages, previously counted as 2 new pages and 2 improved pages, now just counts as 2 improved pages.

af_compare.png (600×1 px, 67 KB)

Similarly for https://eventmetrics-dev.wmflabs.org/programs/91/events/240.

id_compare.png (500×2 px, 107 KB)

For https://eventmetrics-dev.wmflabs.org/programs/91/events/254 I compared stats with what I could derive from the revisions/edit list. Stats report Pages Improved: 91. In the revisions list there are 94 rows, 3 of which refer to the same page.