ButtonWidget (icon only) and without invisibleLabel results in oversized height on IE 10 & 11, Edge 15, 16
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update OOUI to v0.30.3 | mediawiki/core | master | +174 -111 | |
| demos: Address oversized ButtonWidget (icon-only) in IE & Edge | oojs/ui | master | +9 -1 |
Event Timeline
Comment Actions
Change 491663 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Address oversized ButtonWidget (icon-only) in IE & Edge
Comment Actions
This only occurs for this single demo example, and nowhere else. It seems to be caused by the unicode-bidi: bidi-override; rule added in https://gerrit.wikimedia.org/r/c/oojs/ui/+/482703/5/demos/styles/demo.css#422 (it disappears when I remove it). That rule should only apply to elements with a label, but it also applies to these label-less buttons. I don't think we need the workaround in OOUI library code, only in demo code.
Comment Actions
@matmarex It's also happening in NumberInputWidget as the buttons don't have a hidden label as they have aria-hidden applied.
Also I think it's not a good idea to give devs the ability to use such basic widget (even though I'd prefer to have it rendering a warning when there's no aria label :P) resulting in such error.
Comment Actions
Change 491663 merged by jenkins-bot:
[oojs/ui@master] demos: Address oversized ButtonWidget (icon-only) in IE & Edge
Comment Actions
Change 491943 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.3