Page MenuHomePhabricator

demos: ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11, Edge 15
Closed, ResolvedPublic

Description

ButtonWidget (icon only) and without invisibleLabel results in oversized height on IE 10 & 11, Edge 15, 16

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 20 2019, 12:43 AM
Volker_E renamed this task from ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11 to ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11, Edge 15.Feb 20 2019, 12:45 AM
Volker_E updated the task description. (Show Details)

Change 491663 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[oojs/ui@master] WikimediaUI theme: Address oversized ButtonWidget (icon-only) in IE & Edge

https://gerrit.wikimedia.org/r/491663

This only occurs for this single demo example, and nowhere else. It seems to be caused by the unicode-bidi: bidi-override; rule added in https://gerrit.wikimedia.org/r/c/oojs/ui/+/482703/5/demos/styles/demo.css#422 (it disappears when I remove it). That rule should only apply to elements with a label, but it also applies to these label-less buttons. I don't think we need the workaround in OOUI library code, only in demo code.

@matmarex It's also happening in NumberInputWidget as the buttons don't have a hidden label as they have aria-hidden applied.
Also I think it's not a good idea to give devs the ability to use such basic widget (even though I'd prefer to have it rendering a warning when there's no aria label :P) resulting in such error.

Volker_E renamed this task from ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11, Edge 15 to demos: ButtonWidget (icon only) and without `invisibleLabel` results in oversized height on IE 10 & 11, Edge 15.Feb 20 2019, 2:52 AM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Feb 20 2019, 3:20 AM

Change 491663 merged by jenkins-bot:
[oojs/ui@master] demos: Address oversized ButtonWidget (icon-only) in IE & Edge

https://gerrit.wikimedia.org/r/491663

Volker_E closed this task as Resolved.Feb 20 2019, 9:38 PM
Volker_E claimed this task.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Reviewing to OOUI-0.30.2 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.30.2); removed OOUI.
Volker_E removed a project: Patch-For-Review.
Volker_E removed a subscriber: gerritbot.
Volker_E moved this task from OOUI-0.30.2 to OOUI-0.30.3 on the OOUI board.Feb 21 2019, 3:47 AM
Volker_E edited projects, added OOUI (OOUI-0.30.3); removed OOUI (OOUI-0.30.2).

Change 491943 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.30.3

https://gerrit.wikimedia.org/r/491943

Change 491943 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.30.3

https://gerrit.wikimedia.org/r/491943