Page MenuHomePhabricator
Create Task
Maniphest T216734

Drop devDependency on phpunit-mock-objects, which is abandoned and warns against use
Closed, ResolvedPublic
Actions

Description

The functionality was merged into PHPUnit 7.x.

Related Objects
Search...

Event Timeline

Jdforrester-WMF changed the task status from Open to Stalled.Feb 21 2019, 4:36 PM
Jdforrester-WMF triaged this task as Lowest priority.
Jdforrester-WMF created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2019, 4:36 PM
Jdforrester-WMF created subtask T216735: Drop support for PHPUnit 6.x.Feb 21 2019, 4:37 PM
WMDE-leszek subscribed.Feb 22 2019, 8:25 AM
Mainframe98 merged a task: T216796: Warning from composer about abandoning of phpunit/phpunit-mock-objects.Feb 22 2019, 8:30 AM
Mainframe98 added a subscriber: Kizule.
Anomie subscribed.Feb 22 2019, 2:24 PM

I was worried that this meant that we'd have to change all our tests to use some other mocking mechanism, but discussion at https://github.com/sebastianbergmann/phpunit-mock-objects/issues/425 suggests that the functionality was merged into PHPUnit in 7.x. So the functionality should still be there, just without needing to pull in this package.

Jdforrester-WMF added a comment.Feb 22 2019, 3:10 PM
In T216734#4975931, @Anomie wrote:

I was worried that this meant that we'd have to change all our tests to use some other mocking mechanism, but discussion at https://github.com/sebastianbergmann/phpunit-mock-objects/issues/425 suggests that the functionality was merged into PHPUnit in 7.x. So the functionality should still be there, just without needing to pull in this package.

Yeah, sorry, I was just creating this as a structural task so when someone complains I can point them to it. :-)

Jdforrester-WMF updated the task description. (Show Details)Feb 22 2019, 3:10 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Apr 5 2019, 3:51 PM
Krinkle edited subtasks, added: T192167: Upgrade PHPUnit from 4/6 to 8; removed: T216735: Drop support for PHPUnit 6.x.Jul 11 2019, 3:11 PM
MaxSem changed the status of subtask T192167: Upgrade PHPUnit from 4/6 to 8 from Stalled to Open.Oct 4 2019, 6:16 AM
MaxSem closed this task as Resolved.Nov 21 2019, 8:43 PM
MaxSem claimed this task.
MaxSem subscribed.

Gone after we upgraded to PHPUnit 7 in https://gerrit.wikimedia.org/r/552166.

Jdforrester-WMF closed subtask T192167: Upgrade PHPUnit from 4/6 to 8 as Resolved.Jan 23 2020, 4:17 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL