Page MenuHomePhabricator

This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".
Closed, ResolvedPublic2 Estimated Story Points

Description

The following console warning error shows:

This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".

See https://phabricator.wikimedia.org/T205744 for migration info.

i also see

This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".

See https://phabricator.wikimedia.org/T205744 for migration info.

Developer notes

Repeat run of T214444

Acceptance criteria

  • No deprecation messages mentioning QuickSurveys appears in the JavaScript console

QA steps

This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".
See https://phabricator.wikimedia.org/T205744 for migration info.
  • Verify that an event? request shows in the network tab when you filter "QuickSurveyInitiation".
  • Ask a developer to apply the fix to reading web staging.
  • Confirm the console note is gone and that the event? still shows in the developer console.

QA Results

StatusDetails
✅ PassedT216746#5007476

Event Timeline

Jdlrobson triaged this task as Medium priority.Feb 21 2019, 5:21 PM
Jdlrobson moved this task from Incoming to Upcoming on the Readers-Web-Backlog board.
Jdlrobson added a project: Technical-Debt.
Jdlrobson updated the task description. (Show Details)
ovasileva set the point value for this task to 2.Feb 26 2019, 5:19 PM

Change 494498 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/QuickSurveys@master] Remove EventLogging schema module

https://gerrit.wikimedia.org/r/494498

Jdlrobson updated the task description. (Show Details)
Jdlrobson removed a project: Patch-For-Review.
Jdlrobson added a subscriber: pmiazga.

Change 494498 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Remove EventLogging schema module

https://gerrit.wikimedia.org/r/494498

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

STEP 1:
Visit https://reading-web-staging.wmflabs.org/wiki/Test_new_article?quicksurvey=true and verify that the following shows up in the developer console (if it doesn't ask the developer to revert the fix for this step)
This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".

Screen Shot 2019-03-06 at 9.51.44 PM.png (1×1 px, 316 KB)

STEP 2:
Verify that an event? request shows in the network tab when you filter "QuickSurveyInitiation".

Screen Shot 2019-03-06 at 9.53.58 PM.png (1×1 px, 229 KB)

STEP 3:
Ask a developer to apply the fix to reading web staging.
@Jdlrobson can I trouble you to please apply the fix to reading web staging?

(AC1) STEP 4:
Confirm the console note is gone and that the event? still shows in the developer console.

Screen Shot 2019-03-07 at 9.32.30 AM.png (1×1 px, 386 KB)

@Jdlrobson can I trouble you to please apply the fix to reading web staging?

Done!

Edtadros updated the task description. (Show Details)
Edtadros added a subscriber: Edtadros.

@Jdlrobson can I trouble you to please apply the fix to reading web staging?

Done!

Thanks. This is passed!

ovasileva added a subscriber: ovasileva.
Niedzielski added a subscriber: Niedzielski.

Looks good to me. Can the code deprecation warning in EventLogging be dropped or is this still needed by other clients?

Jdlrobson updated the task description. (Show Details)

We're not overseeing the removal of the API in EventLogging so we've done our job here.