This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 21 2019, 5:20 PM

Description

The following console warning error shows:

This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".

See https://phabricator.wikimedia.org/T205744 for migration info.

i also see

This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".

See https://phabricator.wikimedia.org/T205744 for migration info.

Developer notes

Repeat run of T214444

Acceptance criteria

No deprecation messages mentioning QuickSurveys appears in the JavaScript console

QA steps

Visit https://reading-web-staging.wmflabs.org/wiki/Test_new_article?quicksurvey=true and verify that the following shows up in the developer console (if it doesn't ask the developer to revert the fix for this step)

This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".
See https://phabricator.wikimedia.org/T205744 for migration info.

Verify that an event? request shows in the network tab when you filter "QuickSurveyInitiation".
Ask a developer to apply the fix to reading web staging.
Confirm the console note is gone and that the event? still shows in the developer console.

QA Results

Status	Details
✅ Passed	T216746#5007476

Details

	Subject	Repo	Branch	Lines +/-
	Remove EventLogging schema module	mediawiki/extensions/QuickSurveys	master	+2 -4

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T219342 Pageview performance timeline analysis (March 2019)
Resolved	Milimetric	T221281 Remove deprecated EventLogging schema modules
Resolved	Jdlrobson	T216746 This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".

Event Timeline

Jdlrobson created this task.Feb 21 2019, 5:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2019, 5:20 PM

Jdlrobson triaged this task as Medium priority.Feb 21 2019, 5:21 PM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Jdlrobson added a project: Technical-Debt.

Jdlrobson updated the task description. (Show Details)

ovasileva set the point value for this task to 2.Feb 26 2019, 5:19 PM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3); removed Web-Team-Backlog.Feb 26 2019, 5:27 PM

Change 494498 had a related patch set uploaded (by Jdrewniak; owner: Jdrewniak):
[mediawiki/extensions/QuickSurveys@master] Remove EventLogging schema module

https://gerrit.wikimedia.org/r/494498

gerritbot added a project: Patch-For-Review.Mar 5 2019, 3:09 PM

Jdrewniak moved this task from To Do to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 5 2019, 3:10 PM

Jdrewniak mentioned this in rEQSf5b7f62a3331: Remove EventLogging schema module.Mar 5 2019, 3:13 PM

pmiazga claimed this task.Mar 5 2019, 7:14 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 5 2019, 7:39 PM

Jdlrobson reassigned this task from pmiazga to Edtadros.Mar 5 2019, 7:42 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson removed a project: Patch-For-Review.

Jdlrobson added a subscriber: pmiazga.

Change 494498 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Remove EventLogging schema module

https://gerrit.wikimedia.org/r/494498

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 8:00 PM

Jdlrobson moved this task from Needs More Work to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Mar 5 2019, 11:46 PM

Jdlrobson mentioned this in T139317: Allow quicksurvey to target based on edit count.

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):

STEP 1:
Visit https://reading-web-staging.wmflabs.org/wiki/Test_new_article?quicksurvey=true and verify that the following shows up in the developer console (if it doesn't ask the developer to revert the fix for this step)
This page is using the deprecated ResourceLoader module "schema.QuickSurveysResponses".

Screen Shot 2019-03-06 at 9.51.44 PM.png (1×1 px, 316 KB)

STEP 2:
Verify that an event? request shows in the network tab when you filter "QuickSurveyInitiation".

Screen Shot 2019-03-06 at 9.53.58 PM.png (1×1 px, 229 KB)

STEP 3:
Ask a developer to apply the fix to reading web staging.
@Jdlrobson can I trouble you to please apply the fix to reading web staging?

(AC1) STEP 4:
Confirm the console note is gone and that the event? still shows in the developer console.

Screen Shot 2019-03-07 at 9.32.30 AM.png (1×1 px, 386 KB)

@Jdlrobson can I trouble you to please apply the fix to reading web staging?

Done!

In T216746#5008513, @Jdlrobson wrote:

@Jdlrobson can I trouble you to please apply the fix to reading web staging?

Done!

Thanks. This is passed!

Edtadros added a project: Product-QA (RW-Test-Cases).Mar 7 2019, 5:48 PM

ovasileva removed ovasileva as the assignee of this task.Mar 11 2019, 9:48 AM

ovasileva subscribed.

• Niedzielski claimed this task.Mar 11 2019, 5:09 PM

Looks good to me. Can the code deprecation warning in EventLogging be dropped or is this still needed by other clients?

We're not overseeing the removal of the API in EventLogging so we've done our job here.

Milimetric added a parent task: T221281: Remove deprecated EventLogging schema modules.May 14 2019, 2:43 PM

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM

	F28343320: Screen Shot 2019-03-07 at 9.32.30 AM.png
	Mar 7 2019, 5:34 PM

	F28340000: Screen Shot 2019-03-06 at 9.51.44 PM.png
	Mar 7 2019, 5:59 AM

	F28340002: Screen Shot 2019-03-06 at 9.53.58 PM.png
	Mar 7 2019, 5:59 AM

This page is using the deprecated ResourceLoader module "schema.QuickSurveyInitiation".Closed, ResolvedPublic2 Estimated Story PointsActions