All tests are failing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Feb 22 2019, 2:46 PM

Description

All tests are failing after this patch:
https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/492303/3/pwb.py

$ python pwb.py generate_family_file 'https://wiki.musicbrainz.org/' musicbrainz 'n'
/home/travis/virtualenv/python2.7_with_system_site_packages/local/lib/python2.7/site-packages/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
Traceback (most recent call last):
  File "pwb.py", line 191, in <module>
    pwb = pywikibot
NameError: name 'pywikibot' is not defined
The command "python pwb.py generate_family_file 'https://wiki.musicbrainz.org/' musicbrainz 'n'" exited with 1.

Details

	Subject	Repo	Branch	Lines +/-
	Fix the regression occured after 08ad608	pywikibot/core	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: rPWBC08ad6081fe5e: pwb.py: Limit the try clause to the minimum amount of code necessary

Event Timeline

Xqt created this task.Feb 22 2019, 2:46 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 22 2019, 2:46 PM

Xqt claimed this task.Feb 22 2019, 2:47 PM

Xqt triaged this task as High priority.

The patch is here: https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/492332/

Xqt removed Xqt as the assignee of this task.Feb 22 2019, 2:49 PM

looks like a RuntimeError occured when importing pywikibot but sys.exit() isn't executed because the filename starts with 'generate':

except RuntimeError:
    # user-config.py to be created
    if filename is not None and not (filename.startswith('generate_')
        ...
pwb = pywikibot

Change 492332 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Fix the regression occured after 08ad608

https://gerrit.wikimedia.org/r/492332

gerritbot added a project: Patch-For-Review.Feb 22 2019, 3:20 PM

Change 492332 merged by jenkins-bot:
[pywikibot/core@master] Fix the regression occured after 08ad608

https://gerrit.wikimedia.org/r/492332

Dalba closed this task as Resolved.Feb 22 2019, 3:28 PM

Dalba claimed this task.