Page MenuHomePhabricator
Create Task
Maniphest T216837

Edit conflict preview not working on big pages
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

When you get an edit conflict on a bigger page the preview button does not work.

Steps to reproduce:

  1. Create an edit conflict (myself logged-in against myself as an IP) on a wikipage with much text.
  2. Click on Preview
  3. Nothing happens, no preview is shown.

This might also be the problem behind https://www.mediawiki.org/wiki/Topic:Uun8oeocci3h79i7 ( still not investigated fully )

Acceptance Criteria

  • Independent of page size, we can show a preview

Notes
A big page means anything above 2000 Bytes.
This can probably be solved through using a POST request instead of GET

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use POST to submit wikitext to mw.api.parsemediawiki/coremaster+5 -5
Customize query in gerrit

Related Objects

Duplicates Merged Here
T220595: Preview doesn’t work

Event Timeline

JStrodt_WMDE created this task.Feb 22 2019, 4:59 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptFeb 22 2019, 4:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
JStrodt_WMDE updated the task description. (Show Details)Feb 22 2019, 5:03 PM
JStrodt_WMDE updated the task description. (Show Details)Feb 25 2019, 9:33 AM
JStrodt_WMDE added a comment.Feb 25 2019, 12:01 PM

This is the js error I get when I click the preview button:

GET https://de.wikipedia.org/w/api.php?action=parse&format=json&formatversion=2…anuell%20ersetzt%20werden%2E%0A%7C%7B%7BX%7D%7D%20nicht%20geplant%0A%7C%7D 414
WMDE-Fisch subscribed.Feb 25 2019, 12:06 PM
WMDE-Fisch renamed this task from Preview button isn't working (no reaction) to Edit conflict preview not working on big pages.Feb 25 2019, 12:49 PM
WMDE-Fisch updated the task description. (Show Details)
Restricted Application added a subscriber: jeblad. · View Herald TranscriptFeb 25 2019, 12:49 PM
WMDE-Fisch added a comment.Feb 25 2019, 12:50 PM
In T216837#4980453, @JStrodt_WMDE wrote:

This is the js error I get when I click the preview button:

GET https://de.wikipedia.org/w/api.php?action=parse&format=json&formatversion=2…anuell%20ersetzt%20werden%2E%0A%7C%7B%7BX%7D%7D%20nicht%20geplant%0A%7C%7D 414

I just found out that this is related to big pages where the conflicts appear. So the reason behind this is quite straight forward. I updated the issue description accordingly.

WMDE-Fisch added a subscriber: • Lea_WMDE.Feb 25 2019, 1:01 PM
• Lea_WMDE updated the task description. (Show Details)Feb 26 2019, 2:15 PM
• Lea_WMDE set the point value for this task to 5.
Alsee subscribed.Feb 27 2019, 7:09 PM

I believe I just ran into this problem as well. I'd just like to note surprise at 2000 bytes being described as a big. At EnWiki that would be considered an extremely short page.

WMDE-Fisch merged a task: T220595: Preview doesn’t work.Apr 23 2019, 1:43 PM
WMDE-Fisch added a subscriber: • MichaelSchoenitzer_WMDE.
WMDE-Fisch added a project: WMDE-QWERTY-Sprint-2019-04-17.Apr 23 2019, 2:11 PM
awight claimed this task.Apr 23 2019, 3:59 PM
awight moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-04-17 board.
gerritbot added a comment.Apr 23 2019, 9:23 PM

Change 506005 had a related patch set uploaded (by Awight; owner: Adam Wight):
[mediawiki/core@master] Use POST to submit content as a request parameter

https://gerrit.wikimedia.org/r/506005

gerritbot added a project: Patch-For-Review.Apr 23 2019, 9:23 PM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-04-17 board.Apr 23 2019, 9:25 PM

As you said, POST is all that we needed here. I got fancy and only POST when submitting content via a request parameter.

thiemowmde moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-04-17 board.Apr 30 2019, 12:06 PM
gerritbot added a comment.Apr 30 2019, 12:38 PM

Change 506005 merged by jenkins-bot:
[mediawiki/core@master] Use POST to submit wikitext to mw.api.parse

https://gerrit.wikimedia.org/r/506005

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.3; 2019-04-30).Apr 30 2019, 1:00 PM
Tobi_WMDE_SW moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.May 3 2019, 11:36 AM
• Lea_WMDE closed this task as Resolved.May 8 2019, 8:56 AM
• Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-04-17 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits