Regression [production]: Adding a new topic throws an error
Closed, ResolvedPublic
Actions

Description

Replication steps:

visit https://en.m.wikipedia.org/wiki/User_talk:Jdlrobson
click "add discussion"
add subject and topic
hit "Save"

I'm seeing the following error when adding a section to local, non-proxied content:

load.php?debug=false&lang=en&modules=jquery&skin=minerva&version=00rdyep:51 jQuery.Deferred exception: LoadingOverlay is not a constructor TypeError: LoadingOverlay is not a constructor
    at <anonymous>:215:683
    at OoEventEmitter.oo.EventEmitter.emit (<anonymous>:65:486)
    at <anonymous>:102:527
    at mightThrow (http://localhost:8181/w/load.php?debug=false&lang=en&modules=jquery&skin=minerva&version=00rdyep:48:856)
    at process (http://localhost:8181/w/load.php?debug=false&lang=en&modules=jquery&skin=minerva&version=00rdyep:49:516)

The URL in my case is http://localhost:8181/wiki/Talk:Woooo. Let me know if you have trouble reproducing.

QA steps

Ask a developer to turn off API proxying on reading web staging
Visit https://reading-web-staging.wmflabs.org/wiki/User_talk:Jdlrobson as a logged in user on mobile.
Click talk
Click add a discussion
Fill in a topic (subject and text) and hit save
Verify it saved.

QA Results

Status	Details
✅ Passed	T216853#4983623

Details

	Subject	Repo	Branch	Lines +/-
	Correct path for obtaining loadingOverlay	mediawiki/skins/MinervaNeue	master	+3 -3

Customize query in gerrit

Event Timeline

Jdlrobson created this task.Feb 22 2019, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2019, 10:07 PM

Jdlrobson triaged this task as High priority.Feb 22 2019, 10:08 PM

Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

Change 492400 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Correct path for obtaining loadingOverlay

https://gerrit.wikimedia.org/r/492400

Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Feb 22 2019, 10:13 PM

gerritbot added a project: Patch-For-Review.Feb 22 2019, 10:13 PM

Change 492400 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Correct path for obtaining loadingOverlay

https://gerrit.wikimedia.org/r/492400

Jdlrobson moved this task from Needs Code Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Feb 22 2019, 10:27 PM

Jdlrobson removed a project: Patch-For-Review.Feb 22 2019, 10:43 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 22 2019, 11:00 PM

Jdlrobson assigned this task to Edtadros.Feb 25 2019, 7:57 PM

@Edtadros I've setup staging so you can test this!

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Steps and Artifact(s):

Step	Description	Status	Artifact
1	Ask a developer to turn off API proxying on reading web staging	✅	Thanks @Jdlrobson T216853#4982396
2	Visit https://reading-web-staging.wmflabs.org/wiki/User_talk:Jdlrobson as a logged in user on mobile.	✅
3	Click talk	✅
4	Click add a discussion	✅
5	Fill in a topic (subject and text) and hit save	✅
6	Verify it saved.	✅

Edtadros updated the task description. (Show Details)Feb 26 2019, 6:12 AM

Looks good, thanks all

ovasileva moved this task from Backlog to Advanced Mobile Contributions on the Product-QA (RW-Test-Cases) board.Mar 2 2020, 6:39 PM

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptMar 2 2020, 6:39 PM

	F28285990: T216853.png
	Feb 26 2019, 6:11 AM

Regression [production]: Adding a new topic throws an errorClosed, ResolvedPublicActions