Convert GrowthExperiments code to use require()
Closed, ResolvedPublic
Actions

Description

Both the WelcomeSurvey popup (variation C) and the help panel use lots of internal classes that we should move from being attached to a global object to being internally require()d.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/GrowthExperiments	master	+53 -60	Help panel: convert custom data module to package module
	mediawiki/extensions/GrowthExperiments	master	+41 -56	WelcomeSurvey: convert popup code to using require()

Customize query in gerrit

Related Objects

Mentioned In: rEGRE82ee91517c27: Help panel: convert custom data module to package module
rEGREe935f876aa48: Help panel: convert custom data module to package module
rEGRE25f0e17d9f6b: WelcomeSurvey: convert popup code to using require()

Event Timeline

Catrope created this task.Feb 22 2019, 11:50 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 22 2019, 11:50 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 474972 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] WelcomeSurvey: convert popup code to using require()

https://gerrit.wikimedia.org/r/474972

Change 492247 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/GrowthExperiments@master] Help panel: convert custom data module to package module

https://gerrit.wikimedia.org/r/492247

Catrope mentioned this in rEGRE25f0e17d9f6b: WelcomeSurvey: convert popup code to using require().Feb 22 2019, 11:53 PM

Catrope mentioned this in rEGREe935f876aa48: Help panel: convert custom data module to package module.

Catrope mentioned this in rEGRE82ee91517c27: Help panel: convert custom data module to package module.Feb 22 2019, 11:58 PM

Catrope edited projects, added Growth-Team (Current Sprint); removed Growth-Team.Feb 23 2019, 12:46 AM

Catrope moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change 474972 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] WelcomeSurvey: convert popup code to using require()

https://gerrit.wikimedia.org/r/474972

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 25 2019, 3:00 PM

Change 492247 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Help panel: convert custom data module to package module

https://gerrit.wikimedia.org/r/492247

SBisson moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Feb 25 2019, 3:13 PM