Page MenuHomePhabricator

MediaWiki Extension WikiEditor README File typo
Closed, ResolvedPublic

Description

Currently line 8 of the README reads:

wfLoadExtensions( "WikiEditor" );

and it should read:

wfLoadExtension( "WikiEditor" );

there is no function wfLoadExtensions() my wiki crashed when I copied and pasted the code into LocalSettings.php

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 23 2019, 4:34 PM
Reedy added a subscriber: Reedy.

there is no function wfLoadExtensions() my wiki crashed when I copied and pasted the code into LocalSettings.php

Yes there is, but that is not how to call it - https://github.com/wikimedia/mediawiki/blob/master/includes/GlobalFunctions.php#L53-L72

Change 492483 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/WikiEditor@master] Update README

https://gerrit.wikimedia.org/r/492483

Hello Reedy,

Got it, thank you. But then the README still contains an error on line 8. The first argument to the function should be a single element array not a string.

Ingo---

Reedy added a comment.Feb 23 2019, 4:41 PM

Got it, thank you. But then the README still contains an error on line 8. The first argument to the function should be a single element array not a string.

Yup, which is why I didn't close your bug as invalid, and I fixed it in the patch that was posted

My first time doing anything in Phabricator, just set up my first wiki using MediaWiki…total noob. Thanks for your help, take care!

Change 492483 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Update README

https://gerrit.wikimedia.org/r/492483

Fomafix closed this task as Resolved.Feb 23 2019, 6:31 PM
Fomafix assigned this task to Reedy.
Fomafix removed a project: Patch-For-Review.
happy5214 moved this task from Backlog to Closed on the WikiEditor board.Aug 4 2019, 11:34 AM