Page MenuHomePhabricator

HotCat breaks on update from MW1.31.1 to 1.32.0 in skin Monobook
Closed, InvalidPublic

Description

I had Hotcat installed on my v1.31 wiki. When I upgraded I only got a blank page. Enabling debug parameters in Localsettings provided the following error:

Fatal error: Uncaught Error: Class 'WrappedString\WrappedString' not found in /home/intmed1/wiki.umintmed.ca/extensions/Gadgets/GadgetHooks.php:211 Stack trace: #0 /home/intmed1/wiki.umintmed.ca/includes/Hooks.php(174): GadgetHooks::beforePageDisplay(Object(OutputPage), Object(SkinMonoBook)) #1 /home/intmed1/wiki.umintmed.ca/includes/Hooks.php(234): Hooks::callHook('BeforePageDispl...', Array, Array, NULL, 'GadgetHooks::be...') #2 /home/intmed1/wiki.umintmed.ca/includes/OutputPage.php(2703): Hooks::runWithoutAbort('BeforePageDispl...', Array) #3 /home/intmed1/wiki.umintmed.ca/includes/exception/MWExceptionRenderer.php(136): OutputPage->output() #4 /home/intmed1/wiki.umintmed.ca/includes/exception/MWExceptionRenderer.php(53): MWExceptionRenderer::reportHTML(Object(Error)) #5 /home/intmed1/wiki.umintmed.ca/includes/exception/MWExceptionHandler.php(98): MWExceptionRenderer::output(Object(Error), 2) #6 /home/intmed1/wiki.umintmed.ca/includes/exception/MWExceptionHandler.php(172): MWExceptionHandler::report(Object(Error)) #7 / in /home/intmed1/wiki.umintmed.ca/extensions/Gadgets/GadgetHooks.php on line 211

I have also put this on

I tried to give this error a tag for HotCat but was getting errors

Event Timeline

Judging by the error message and line numbers, you're trying to use a REL1_28 (MediaWiki 1.28-compatible) version of Gadgets on MediaWiki 1.32.0 (in REL1_28, line 211 of /extensions/Gadgets/GadgetsHooks.php references the WrappedString class and L23 of the same file shows that unlike in more current releases, the WrappedString class is expected to exist in its own namespace, as opposed to in REL1_32 and master, where it exists in the "Wikimedia" namespace; see, for example, L24 and L222 of the REL1_32 version of Gadgets).

Try upgrading your copy of Gadgets to its REL1_32 version. You should be able to do this via Special:ExtensionDistributor/Gadgets on MediaWiki.org, for example. You'll also want to make sure that any and all other extensions are also using a REL1_32 version.

@Aklapper: I think it is related to Monobook because it works in Vector. I usually have vector disabled on this wiki, but enabled it just to test. Config change to vector, works. Gadget Hotcat enabled, works. Config change to Monobook, crashes. Disable gadget in Localsettings, works again. Disable hotcat in Gadget settings, and then enable monobook again, works.

Tenbergen claimed this task.

@ashley: You are right, my update process was wrong and retained old extensions for those that come with mediawiki. Once I replaced Gadget with the newest version this worked.

Aklapper changed the task status from Resolved to Invalid.Feb 24 2019, 7:27 PM
Aklapper removed a project: MonoBook.

Setting status to invalid as there was no error in the code.