Page MenuHomePhabricator
Create Task
Maniphest T216904

Upgrade AbuseFilter extension to use newer phan
Closed, ResolvedPublic
Actions

Description

AbuseFilter needs to be upgraded to a newer version of phan, our PHP static analysis tool. This brings in
over 2 years of upstream improvements and lots of bug fixes.

Please follow the instructions on how to migrate at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Migrating_from_phan_0.8.0.

Please also set the Gerrit topic for all patches related to this effort with new-phan-plz.

Details

SubjectRepoBranchLines +/-
Migrate to new phanmediawiki/extensions/AbuseFiltermaster+21 -25
Customize query in gerrit

Event Timeline

Legoktm added projects: AbuseFilter, MediaWiki-Core-Tests.Feb 24 2019, 7:22 AM
Legoktm subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2019, 7:22 AM
Legoktm edited projects, added phan; removed MediaWiki-Core-Tests.Feb 24 2019, 7:24 AM
gerritbot subscribed.Feb 24 2019, 7:42 AM

Change 492530 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/AbuseFilter@master] [WIP] Migrate to new phan

https://gerrit.wikimedia.org/r/492530

gerritbot added a project: Patch-For-Review.Feb 24 2019, 7:42 AM
Daimona subscribed.Feb 24 2019, 8:29 AM

Yes please! I tried this version of phan (or a similar one) on CodeClimate some time ago and it rocks!

Daimona added a comment.Feb 28 2019, 7:34 PM

Se we have:

  • a false positive in AbuseFilterHooks for which I filed https://github.com/phan/phan/issues/2504 and is fixed in 1.2.6.
  • several OOUI-related complaints, all related to function parameters, which I still have to look at
  • a couple of suppressable issues (one with preg_match on null, another for too many params to a function)
  • a few other troubles, mostly resolvable with docblock changes
Huji awarded a token.Feb 28 2019, 8:26 PM
gerritbot added a comment.Mar 16 2019, 7:53 PM

Change 492530 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Migrate to new phan

https://gerrit.wikimedia.org/r/492530

Daimona closed this task as Resolved.Mar 16 2019, 7:59 PM
Daimona claimed this task.
Daimona removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 5:02 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL