Page MenuHomePhabricator
Create Task
Maniphest T216910

Upgrade CirrusSearch extension to use newer phan
Closed, ResolvedPublic
Actions

Description

CirrusSearch needs to be upgraded to a newer version of phan, our PHP static analysis tool. This brings in
over 2 years of upstream improvements and lots of bug fixes.

Please follow the instructions on how to migrate at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Migrating_from_phan_0.8.0.

Please also set the Gerrit topic for all patches related to this effort with new-phan-plz.

Details

SubjectRepoBranchLines +/-
Update phan configmediawiki/extensions/CirrusSearchmaster+100 -106
Customize query in gerrit

Event Timeline

Legoktm added projects: CirrusSearch, MediaWiki-Core-Tests.Feb 24 2019, 7:22 AM
Legoktm subscribed.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptFeb 24 2019, 7:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Legoktm edited projects, added phan; removed MediaWiki-Core-Tests.Feb 24 2019, 7:26 AM
gerritbot subscribed.Feb 27 2019, 7:11 PM

Change 493293 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/CirrusSearch@master] Update phan config

https://gerrit.wikimedia.org/r/493293

gerritbot added a project: Patch-For-Review.Feb 27 2019, 7:11 PM
gerritbot added a comment.Feb 28 2019, 8:45 AM

Change 493293 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Update phan config

https://gerrit.wikimedia.org/r/493293

debt edited projects, added Discovery-Search (Current work); removed Discovery-Search.Feb 28 2019, 6:09 PM
debt subscribed.

this was merged already

Smalyshev triaged this task as Medium priority.Feb 28 2019, 6:30 PM
Smalyshev raised the priority of this task from Medium to Needs Triage.
Smalyshev triaged this task as Medium priority.
Smalyshev moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
Legoktm closed this task as Resolved.Feb 28 2019, 6:49 PM
Legoktm assigned this task to Smalyshev.
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 12:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL