Page MenuHomePhabricator
Create Task
Maniphest T216920

Upgrade GeoData extension to use newer phan
Closed, ResolvedPublic
Actions

Description

GeoData needs to be upgraded to a newer version of phan, our PHP static analysis tool. This brings in
over 2 years of upstream improvements and lots of bug fixes.

Please follow the instructions on how to migrate at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Migrating_from_phan_0.8.0.

Please also set the Gerrit topic for all patches related to this effort with new-phan-plz.

Details

SubjectRepoBranchLines +/-
Bump version of mediawiki/mediawiki-phan-config to 0.4.0mediawiki/extensions/GeoDatamaster+1 -1
Upgrade phan to 1.2.0mediawiki/extensions/GeoDatamaster+27 -27
Customize query in gerrit

Event Timeline

Legoktm added projects: GeoData, phan.Feb 24 2019, 7:29 AM
Legoktm subscribed.
Restricted Application added a project: Discovery-Search. · View Herald TranscriptFeb 24 2019, 7:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
debt triaged this task as Medium priority.Feb 28 2019, 6:09 PM
debt moved this task from needs triage to elastic / cirrus on the Discovery-Search board.
EBernhardson claimed this task.Feb 28 2019, 8:00 PM
EBernhardson moved this task from elastic / cirrus to Current work on the Discovery-Search board.
EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search.
gerritbot subscribed.Feb 28 2019, 8:01 PM

Change 493497 had a related patch set uploaded (by EBernhardson; owner: EBernhardson):
[mediawiki/extensions/GeoData@master] Upgrade phan to 1.2.0

https://gerrit.wikimedia.org/r/493497

gerritbot added a project: Patch-For-Review.Feb 28 2019, 8:01 PM
EBernhardson moved this task from Incoming to Needs review on the Discovery-Search (Current work) board.Feb 28 2019, 8:21 PM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.
gerritbot added a comment.Feb 28 2019, 8:28 PM

Change 493497 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Upgrade phan to 1.2.0

https://gerrit.wikimedia.org/r/493497

MaxSem closed this task as Resolved.Feb 28 2019, 8:28 PM
gerritbot added a comment.Mar 2 2019, 2:41 AM

Change 493776 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/GeoData@master] Bump version of mediawiki/mediawiki-phan-config to 0.4.0

https://gerrit.wikimedia.org/r/493776

Legoktm reopened this task as Open.Mar 2 2019, 7:26 AM
Legoktm added a subscriber: Kizule.

phan isn't actually passing, good catch by @Zoranzoki21.

gerritbot added a comment.Mar 2 2019, 8:17 PM

Change 493776 merged by jenkins-bot:
[mediawiki/extensions/GeoData@master] Bump version of mediawiki/mediawiki-phan-config to 0.4.0

https://gerrit.wikimedia.org/r/493776

Kizule closed this task as Resolved.Mar 2 2019, 8:21 PM

Looks good now, reclosing as resolved :)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 1:04 PM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.21; 2019-03-12); removed MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 2:04 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL