Page MenuHomePhabricator

Upgrade StopForumSpam extension to use newer phan
Open, Needs TriagePublic

Description

StopForumSpam needs to be upgraded to a newer version of phan, our PHP static analysis tool. This brings in
over 2 years of upstream improvements and lots of bug fixes.

Please follow the instructions on how to migrate at https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension#Migrating_from_phan_0.8.0.

Please also set the Gerrit topic for all patches related to this effort with new-phan-plz.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2019, 7:29 AM
Restricted Application added a project: User-Zoranzoki21. · View Herald TranscriptFeb 25 2019, 8:22 PM

Change 492762 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/StopForumSpam@master] Upgrade StopForumSpam to use newer version of phan

https://gerrit.wikimedia.org/r/492762

I am not sure how I can fix:

includes/BlacklistManager.php:90 PhanTypeInvalidRightOperandOfIntegerOp Invalid operator: right operand of << is mixed (expected int)
21:25:43 includes/BlacklistUpdate.php:72 PhanTypeArraySuspiciousNullable Suspicious array access to nullable ?array|?false
21:25:43 includes/BlacklistUpdate.php:78 PhanTypeArraySuspiciousNullable Suspicious array access to nullable ?array|?false
21:25:43 includes/BlacklistUpdate.php:87 PhanTypeInvalidRightOperandOfIntegerOp Invalid operator: right operand of << is mixed (expected int)

I am not sure how I can fix:

(Answered on gerrit.)

Change 492762 had a related patch set uploaded (by Legoktm; owner: Zoranzoki21):
[mediawiki/extensions/StopForumSpam@master] Upgrade StopForumSpam to use newer version of phan

https://gerrit.wikimedia.org/r/492762