Replace casting functions with direct casting
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Reedy
	Feb 24 2019, 10:34 PM

Description

Forking from T216969: API inconsistently uses int casting methods, it would be nice if we could use codesniffer to use (int) et al rather than intval()

We might be able to reuse https://github.com/dereuromark/cakephp-codesniffer/blob/master/Vendor/PHP/CodeSniffer/Standards/MyCakePHP/Sniffs/PHP/CastSniff.php

Details

	Subject	Repo	Branch	Lines +/-
	Replace casting functions with casts	mediawiki/tools/codesniffer	master	+362 -0
	Split cast operator logic from "forbidden functions" sniff	mediawiki/tools/codesniffer	master	+373 -294

Customize query in gerrit

Related Objects

Mentioned Here: T216969: API inconsistently uses int casting methods

Event Timeline

Reedy created this task.Feb 24 2019, 10:34 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2019, 10:34 PM

Reedy updated the task description. (Show Details)Feb 24 2019, 10:54 PM

Mainframe98 claimed this task.Feb 25 2019, 7:16 AM

Change 492634 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/tools/codesniffer@master] Replace casting functions with casts

https://gerrit.wikimedia.org/r/492634

gerritbot added a project: Patch-For-Review.Feb 25 2019, 10:13 AM

Change 493656 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/tools/codesniffer@master] Split cast operator logic from "forbidden functions" sniff

https://gerrit.wikimedia.org/r/493656

xSavitar awarded a token.Mar 5 2019, 6:28 PM

xSavitar subscribed.

Change 493656 abandoned by Thiemo Kreuz (WMDE):
Split cast operator logic from "forbidden functions" sniff

https://gerrit.wikimedia.org/r/493656

Ricordisamoa subscribed.Jan 14 2020, 1:01 PM

DannyS712 moved this task from Untriaged to Proposed rule changes on the MediaWiki-Codesniffer board.Jun 7 2021, 1:47 PM

Change 492634 abandoned by Mainframe98:

[mediawiki/tools/codesniffer@master] Replace casting functions with casts

Reason:

There hasn't been sufficient buy-in to continue with this

https://gerrit.wikimedia.org/r/492634