Page MenuHomePhabricator
Create Task
Maniphest T217009

Cite: Hardcoded 'mwReference' name makes subclassing difficult
Open, Needs TriagePublic
Actions

Description

The 'mwReference' static name property of ve.dm.MWReference class is used in related classes as hardcoded value as seen in https://codesearch.wmflabs.org/extensions/?q=mwReference&i=nope&files=&repos=

This makes subclassing of ve.dm.MWReferenceNode with a different name difficult. The associated inspectors stop working, and the code breaks in number of places. Example: https://phabricator.wikimedia.org/T203160#4738735

Event Timeline

• santhosh created this task.Feb 25 2019, 11:22 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2019, 11:22 AM
• santhosh updated the task description. (Show Details)Feb 25 2019, 11:23 AM
Izno added a project: VisualEditor.Apr 9 2019, 5:50 PM
Izno moved this task from Unsorted backlog to External on the Cite board.
JTannerWMF added subscribers: Esanders, JTannerWMF.May 7 2019, 3:14 PM

Can you look into this @Esanders

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.May 7 2019, 3:14 PM
JTannerWMF moved this task from Incoming to Investigating on the VisualEditor (Current work) board.
matmarex subscribed.May 7 2019, 4:10 PM

I don't know a lot about CX integration, so I'm sorry if this is a silly idea. But would it be possible to unregister ve.dm.MWReferenceNode from the model registry, and instead register your ve.dm.CXReferenceNode under the name 'mwReference'?

JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 5 2020, 12:10 AM
matmarex added a project: VisualEditor.Feb 5 2020, 1:04 AM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 12 2020, 5:24 PM
MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:59 PM
MBinder_WMF moved this task from Kanban Board to Next Quarter on the Editing-team board.Mar 17 2021, 10:18 PM
MBinder_WMF edited projects, added Editing-team; removed Editing-team (Kanban Board).
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL