Page MenuHomePhabricator
Create Task
Maniphest T217013

Hide section edit actions
Closed, ResolvedPublic
Actions

Description

When content is delivered on an external translation service it cannot be edited directly. Currently, the pencil icon is visible for each section (example) where it should be hidden instead. Note the pencil icon in the "Deskripsi" section below:

Screenshot 2019-02-25 at 12.46.49.png (777×1 px, 253 KB)

The issue happens on both, mobile and desktop.

Details

SubjectRepoBranchLines +/-
Remove transition for hiding the edit icons in sectionsmediawiki/extensions/ExternalGuidancemaster+2 -3
Customize query in gerrit

Event Timeline

Pginer-WMF created this task.Feb 25 2019, 11:50 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2019, 11:50 AM
Pginer-WMF triaged this task as Medium priority.Feb 25 2019, 11:50 AM
Pginer-WMF added a subscriber: santhosh.
gerritbot added a subscriber: gerritbot.Feb 25 2019, 12:23 PM

Change 492658 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ExternalGuidance@master] Remove transition for hiding the edit icons in sections

https://gerrit.wikimedia.org/r/492658

santhosh claimed this task.Feb 25 2019, 12:23 PM
gerritbot added a project: Patch-For-Review.Feb 25 2019, 12:23 PM
santhosh moved this task from Backlog to In Review on the ExternalGuidance board.Feb 25 2019, 12:23 PM
santhosh moved this task from In Review to Done on the ExternalGuidance board.Feb 26 2019, 3:42 AM
santhosh moved this task from Done to In Review on the ExternalGuidance board.
gerritbot added a comment.Feb 26 2019, 10:39 PM

Change 492658 merged by jenkins-bot:
[mediawiki/extensions/ExternalGuidance@master] Remove transition for hiding the edit icons in sections

https://gerrit.wikimedia.org/r/492658

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 11:03 AM
santhosh moved this task from In Review to Done on the ExternalGuidance board.Mar 14 2019, 5:30 AM
Pginer-WMF closed this task as Resolved.Mar 14 2019, 8:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL