Page MenuHomePhabricator

Ensure all CSS selectors are prefixed
Open, NormalPublic

Description

To avoid clash with other code, here is a list of violations excluding the following prefixes:
/(mw|oo-ui|cx|ve|skin|client|card)-|card__/

(arguably the card-/card__ prefix is too generic too)

I imagine a fair few of these are in deprecated CX1 code and so can probably be ignored.

modules/dashboard/styles/ext.cx.dashboard.less
 6:1  ✖  ".translation-filter"

modules/dashboard/styles/ext.cx.dashboard.monobook.less
 1:1  ✖  ".translation-filter"

modules/dashboard/styles/mw.cx.SuggestionList.less
 170:3   ✖  ".source-title"

modules/dashboard/styles/mw.cx.TranslationList.less
  62:3  ✖  ".last-updated"
  68:3  ✖  ".translation-link"
  74:5  ✖  ".disabled"
  79:4  ✖  ".source-title"
  85:4  ✖  ".target-title"
  91:4  ✖  ".source-title"
  92:4  ✖  ".target-title"
 103:3  ✖  ".status"
 111:3  ✖  ".status-deleted"
 115:3  ✖  ".status-published"

modules/entrypoint/styles/ext.cx.entrypoint.less
 16:2  ✖  ".icon-close"

modules/entrypoint/styles/ext.cx.interlanguagelink.less
 3:28  ✖  ".new"

modules/entrypoint/styles/ext.cx.interlanguagelink.vector.less
 5:17  ✖  ".portal"
 5:28  ✖  ".body"
 5:67  ✖  ".new"

modules/stats/styles/ext.cx.stats.less
  51:4  ✖  ".separator"
 106:4  ✖  ".tail"
 210:5  ✖  ".increase"
 214:5  ✖  ".decrease"

modules/tools/styles/ext.cx.tools.card.less
 3:1  ✖  ".card"

modules/tools/styles/ext.cx.tools.dictionary.less
 3:1  ✖  ".card"
 3:6  ✖  ".dictionary"

modules/tools/styles/ext.cx.tools.formatter.less
 29:4  ✖  ".highlight"

modules/tools/styles/ext.cx.tools.instructions.less
  3:1   ✖  ".card"
  3:6   ✖  ".instructions"
  9:15  ✖  ".guidelines"
 16:1   ✖  ".instruction"
 16:13  ✖  ".text"
 20:2   ✖  ".heading"
 24:2   ✖  ".description"
 33:1   ✖  ".tools"
 33:7   ✖  ".serial"
 33:14  ✖  ".number"

modules/tools/styles/ext.cx.tools.link.less
   4:1   ✖  ".cards"
   4:7   ✖  ".link"
  14:2   ✖  ".card"
  26:14  ✖  ".card"
 118:1   ✖  ".card"
 118:6   ✖  ".missinglink"
 133:1   ✖  ".card"
 133:6   ✖  ".redlink"
 164:2   ✖  ".shortcut-info"
 196:1   ✖  ".external"

modules/tools/styles/ext.cx.tools.linker.less
  3:1  ✖  ".card"
  3:6  ✖  ".linker"
  8:3  ✖  ".linker-expanded"
  9:3  ✖  ".linker-trigger"
 13:3  ✖  ".linker-search"
 14:3  ✖  ".linker-header"
 19:2  ✖  ".linker-trigger"
 30:2  ✖  ".linker-search"
 43:2  ✖  ".linker-external-link"
 55:2  ✖  ".linker-header"
 58:3  ✖  ".linker-internal"
 59:3  ✖  ".linker-external"
 65:3  ✖  ".linker-internal"
 74:3  ✖  ".linker-inactive"

modules/tools/styles/ext.cx.tools.mt.card.less
  3:1  ✖  ".card"
  3:6  ✖  ".mt"
 38:5  ✖  ".selected"

modules/tools/styles/ext.cx.tools.mtabuse.less
 4:1  ✖  ".card"
 4:6  ✖  ".mtabuse"

modules/tools/styles/ext.cx.tools.reference.less
 53:1  ✖  ".card"
 53:6  ✖  ".reference"

modules/tools/styles/ext.cx.tools.template.card.less
   3:1  ✖  ".card"
   3:6  ✖  ".template"
  20:5  ✖  ".selected"
 103:1  ✖  ".placeholder"

modules/translation/styles/ext.cx.translation.less
 25:1  ✖  ".placeholder"

modules/ui/legacy/styles/mw.cx.ui.Columns.less
 7:3  ✖  ".disabled"

modules/ui/legacy/styles/mw.cx.ui.Header.less
 101:5   ✖  ".uls-trigger"
 185:11  ✖  ".sticky"

modules/ui/legacy/styles/mw.cx.ui.ToolsColumn.less
 17:3  ✖  ".sticky"

modules/ui/legacy/styles/mw.cx.ui.TranslationColumn.less
 14:1  ✖  ".placeholder"

modules/ui/legacy/styles/mw.cx.ui.TranslationView.less
 31:1  ✖  ".suggestion"

modules/ui/styles/mw.cx.mixins.less
 49:1  ✖  ".flex-around( @direction: column )"

modules/ui/styles/mw.cx.ui.Columns.less
 14:3  ✖  ".disabled"

modules/ui/styles/mw.cx.ui.Header.less
 107:5  ✖  ".uls-trigger"

modules/ui/styles/mw.cx.ui.Header.monobook.less
 38:2  ✖  ".translation-filter"

modules/ui/styles/mw.cx.ui.TargetColumn.less
 27:1  ✖  ".placeholder"

modules/ui/styles/mw.cx.ui.ToolsColumn.less
 17:3  ✖  ".sticky"
 36:4  ✖  ".sticky"

modules/ui/styles/mw.cx.ui.TranslationHeader.less
 25:3  ✖  ".sticky"

modules/ui/styles/mw.cx.ui.TranslationView.less
 30:1  ✖  ".suggestion"

modules/ui/styles/widgets/mw.cx.ui.MessageWidget.less
 19:3  ✖  ".details"

modules/widgets/spinner/ext.cx.spinner.less
  8:2  ✖  ".bounce1"
 13:2  ✖  ".bounce2"

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2019, 12:52 PM

@Esanders I am an outreachy applicant, I would like to work on this.

Esanders added a subscriber: Arrbee.EditedFeb 25 2019, 5:52 PM

Sounds like a good starter task to me, but this is not my team :) cc @Arrbee ^^

Hi @Ifygal3 , thanks for your interest. This is perhaps not the ideal task we can help you with as it may be hard to follow up and test across a pretty vast deprecated codebase and a heavily active one. Sorry :(

Arrbee triaged this task as Normal priority.Mar 4 2019, 2:46 PM
Arrbee moved this task from Needs Triage to Enhancements on the ContentTranslation board.