Page MenuHomePhabricator

Add feature flag to enable/disable metadata step
Closed, ResolvedPublic

Description

The metadata step is already conditional (checks MediaInfo JS module existence & $wgUploadWizardConfig['wikibase']['enabled'] config var), but this is not enough for launch.
We need a separate variable that prevents the metadata step from being loaded, so that we can have this additional step only on beta (and not in production) for some time.

$wgUploadWizardConfig['wikibase']['enabled'] doesn't suffice because that would also turn captions off...

Event Timeline

Also added ['captions'] and ['depicts'], to allow each of them to be turned on/off individually, in addition to the global ['enabled']
Both default to true right now ('enabled' defaults to false), so ['depicts'] will need to be overwritten in prod config until we want to enable this, since 'enabled' is already true there.

UPDATE: changed 'depicts' to default to false, so we can let UW patch roll forward with train, without having to add config until we want to turn things on.

Change 471919 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Change 499523 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[operations/mediawiki-config@master] SDC: Enable feature flag for depicts in UW on Test Commons

https://gerrit.wikimedia.org/r/499523

Feature flag is live in production config, disabled except for Beta Cluster.

Change 471919 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Change 499523 merged by jenkins-bot:
[operations/mediawiki-config@master] SDC: Enable feature flag for depicts in UW on Test Commons

https://gerrit.wikimedia.org/r/499523

Change 507943 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[operations/mediawiki-config@master] SDC: Enable feature flag for depicts in UW on Commons

https://gerrit.wikimedia.org/r/507943

Change 507943 merged by jenkins-bot:
[operations/mediawiki-config@master] SDC: Enable feature flag for depicts in UW on Commons

https://gerrit.wikimedia.org/r/507943