Page MenuHomePhabricator

Aborted deploy does not revert config changes
Open, MediumPublic

Description

Today's deploy made a config change and submodule change,
https://github.com/wikimedia/mediawiki-services-parsoid-deploy/commit/cb62482a8f25931b86757b3ff26f8e9565f4005d
https://github.com/wikimedia/mediawiki-services-parsoid-deploy/commit/011dbb31084f8801c7fbaa3f829970a07c1aea32

Deploying to the canaries caught T217093 so the deploy was aborted. However, while the all nodes were returned to the right submodule commit, the config changed was not reverted. For example, wtp1025 still has num_workers: 3

Event Timeline

greg triaged this task as Medium priority.Jul 26 2019, 12:49 AM
greg moved this task from Needs triage to Debt on the Scap board.