Page MenuHomePhabricator

Popups schema has the wrong type for popupDelay
Closed, ResolvedPublic

Description

This schema is used very sparingly now, but we discovered a bug in how the popupDelay value was stored. The refine process inferred it was an integer and we're not sure if the data in the field is correct or cast down from a meaningful number like 0 < x < 1. Please advise.

Event Timeline

phuedx closed this task as Resolved.Feb 27 2019, 10:30 AM
phuedx claimed this task.
phuedx added a subscriber: phuedx.

@Tbayer pointed me at this task during our 1:1 yesterday.

AFAICT it's the inferred type that is correct rather than the type specified in the schema as the underlying value is specified as a whole number of milliseconds (IIRC it should always be 500 ms).

I've updated the type of the property to match that of the perceivedWait property.