HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue)
Closed, ResolvedPublic
Actions

Description

Several days ago the HHVM job of the Wikibase Travis CI build started to fail, see e.g. https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/498420867

The error reported (see below) stems from the recently merged change in MediaWiki https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/485341/

Catchable fatal error: Argument 1 passed to Mediawiki\Logger\LogCapturingSpi::__construct() must implement interface Mediawiki\Logger\Spi, MediaWiki\Logger\LegacySpi given in /home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiLoggerPHPUnitTestListener.php on line 28

The error seems interesting, as MediaWiki\Logger\LegacySpi actually implements Mediawiki\Logger\Spi.

I started to suspect there is some weird bug in HHVM, which causes the error. Interestingly, Travis seem to run HHVM 3.24, whereas WMF Jenkins CI, same as WMF production, run HHVM 3.18. This could support, or not, the bug in HHVM explanation hypothesis.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+5 -5	Fix lowercase in namespace of LogCapturingSpi.php

Customize query in gerrit

Event Timeline

WMDE-leszek created this task.Feb 26 2019, 10:52 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2019, 10:52 AM

WMDE-leszek moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.Feb 26 2019, 10:55 AM

It's amazing, the LegacySpi is MediaWiki\Logger\ namespace but LogCapturingSpi is in Mediawiki\Logger\ namespace (lowercase w in mediawiki)

Change 493008 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Fix lowercase in namespace of LogCapturingSpi.php

https://gerrit.wikimedia.org/r/493008

gerritbot added a project: Patch-For-Review.Feb 26 2019, 12:18 PM

Ladsgroup claimed this task.Feb 26 2019, 12:18 PM

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 26 2019, 12:18 PM

Change 493008 merged by jenkins-bot:
[mediawiki/core@master] Fix lowercase in namespace of LogCapturingSpi.php

https://gerrit.wikimedia.org/r/493008

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.19; 2019-02-26).Feb 26 2019, 1:00 PM

Looks it is fixed https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/498678262

HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue)Closed, ResolvedPublicActions

Description

Details

Event Timeline

HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue)
Closed, ResolvedPublic
Actions