Page MenuHomePhabricator

HHVM job of the Wikibase Travis CI builds failing (non-Wikibase test being the issue)
Closed, ResolvedPublic

Description

Several days ago the HHVM job of the Wikibase Travis CI build started to fail, see e.g. https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/498420867

The error reported (see below) stems from the recently merged change in MediaWiki https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/485341/

Catchable fatal error: Argument 1 passed to Mediawiki\Logger\LogCapturingSpi::__construct() must implement interface Mediawiki\Logger\Spi, MediaWiki\Logger\LegacySpi given in /home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiLoggerPHPUnitTestListener.php on line 28

The error seems interesting, as MediaWiki\Logger\LegacySpi actually implements Mediawiki\Logger\Spi.

I started to suspect there is some weird bug in HHVM, which causes the error. Interestingly, Travis seem to run HHVM 3.24, whereas WMF Jenkins CI, same as WMF production, run HHVM 3.18. This could support, or not, the bug in HHVM explanation hypothesis.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2019, 10:52 AM

It's amazing, the LegacySpi is MediaWiki\Logger\ namespace but LogCapturingSpi is in Mediawiki\Logger\ namespace (lowercase w in mediawiki)

Change 493008 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/core@master] Fix lowercase in namespace of LogCapturingSpi.php

https://gerrit.wikimedia.org/r/493008

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptFeb 26 2019, 12:18 PM

Change 493008 merged by jenkins-bot:
[mediawiki/core@master] Fix lowercase in namespace of LogCapturingSpi.php

https://gerrit.wikimedia.org/r/493008