Page MenuHomePhabricator

Add monolingual language code gml (Middle Low German)
Closed, ResolvedPublic

Description

Please add the language code gml for Middle Low German to the list of language codes supported for monolingual text values.

Usage example: Q28031376#P1476

Event Timeline

I would like to contribute on this issue.

@Shubham656jain @Diwanshu885 There is no approval of the LangCom yet, so this task can't be worked on.

@jhsoby @Amire80 What's your opinion on adding this language?

@Shubham656jain @Diwanshu885 If you're still interested one of you can claim this task and work on it.

Hi @Mbch331 I have seen the example mentioned above and the list of language codes (https://www.wikidata.org/wiki/Help:Wikimedia_language_codes/lists/all).
gml is already added in this list but is not showing as a language code in the example . Can you tell me what exactly needs to be done? I'm very new to opensource. Thanks!

Wikibase had a property of the type Monolingual languages. They use the default languages available by Wikimedia and a few extra languages that aren't in the default list.
The list you refer to isn't related to this request.
It needs a code change in Wikibase.
You need to change the file lib/includes/WikibaseContentLanguages.php in https://gerrit.wikimedia.org/r/mediawiki/extensions/Wikibase

Yeah I have added gml in the code. I was just trying to figure out how to make a pull request in gerrit, it's a bit different than github.

Yeah I have added gml in the code. I was just trying to figure out how to make a pull request in gerrit, it's a bit different than github.

Check out https://www.mediawiki.org/wiki/Gerrit/Tutorial

Nikki renamed this task from Add monolingual language code gml to Add monolingual language code gml (Middle Low German).Oct 12 2020, 12:16 PM

@Mbch331 I have added the gml in the code and have also made a pull request in Gerrit for code review. Do I need to do something else? Please guide.

Change 633555 had a related patch set uploaded (by DannyS712; owner: Diwanshu885):
[mediawiki/extensions/Wikibase@master] Added gml language code into the list of monolingual language codes.

https://gerrit.wikimedia.org/r/633555

@Mbch331 I have added the gml in the code and have also made a pull request in Gerrit for code review. Do I need to do something else? Please guide.

The bug should be mentioned in the commit message so that the bot adds a comment about it here. I have updated the commit message for you

@DannyS712 Thanks for the help. Is something else I need to change?

@Diwanshu885 gml comes before gmy in the alphabet, so that needs to be fixed. For the rest it's correct.

Change 633684 had a related patch set uploaded (by Mbch331; owner: Mbch331):
[mediawiki/extensions/cldr@master] Add monolingual code gml (Middle Low German)

https://gerrit.wikimedia.org/r/633684

Change 633555 had a related patch set uploaded (by Diwanshu885; owner: Diwanshu885):
[mediawiki/extensions/Wikibase@master] Added gml language code into the list of monolingual language codes.

https://gerrit.wikimedia.org/r/633555

Patch is now correct. Rest is up to @Lydia_Pintscher and her team

Yay :) Thanks everyone!
Putting it in the right spot to get it merged.

Change 633684 merged by jenkins-bot:
[mediawiki/extensions/cldr@master] Add monolingual code gml (Middle Low German)

https://gerrit.wikimedia.org/r/633684

@Diwanshu885 No need to start tagging people on Gerrit. It's been brought to the attention of the correct people. It will get reviewed. No need to rush. Code deployment is only once a week, so whether it gets merged now, later today or tomorrow doesn't matter. Change won't go live till next week.

Change 633555 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Added gml language code into the list of monolingual language codes.

https://gerrit.wikimedia.org/r/633555

Thanks everyone! This should go out next week :)