Page MenuHomePhabricator

Special:AbuseFilter description and notes have too low of a contrast ratio for unprivileged users
Closed, ResolvedPublic

Description

If a user does not have the necessary rights to edit filters, Special:AbuseFilter greys out the Description and Notes fields. The text is #72777d and the background is #eaecf0, resulting in a contrast ratio of 3.817:1 according to this tool. This is below the Web Content Accessibility Guidelines 2.0 AA standard of 4.5:1 for small text meaning that it is hard to read. This is undesirable as all editors should be able to read abuse filter notes and descriptions even if they can not edit them.

Example page: https://en.wikipedia.org/wiki/Special:AbuseFilter/1

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2019, 3:57 PM

I agree that grayed fields are not very easy to read. I'm also making it clear that (as you probably suspected) this is strictly related to OOUI, which defines the colors.

Volker_E added a subscriber: Volker_E.EditedFeb 26 2019, 7:37 PM

That should be a readonly field and not a disabled one. readonly would conform to level AA and also seems semantically more appropriate for this widget.

Daimona claimed this task.EditedFeb 26 2019, 7:40 PM

@Volker_E Thanks for the input, it definitely makes sense. I'm unsure why I chose disabled upon submitting the change. Patch coming shortly tomorrow.

Change 493190 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Make text fields use readonly instead of disabled

https://gerrit.wikimedia.org/r/493190

Change 493190 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Make text fields use readonly instead of disabled

https://gerrit.wikimedia.org/r/493190

Daimona closed this task as Resolved.Mar 17 2019, 9:50 AM
Daimona removed a project: Patch-For-Review.