Page MenuHomePhabricator

Visual changes to translate descriptions
Closed, ResolvedPublic5 Estimated Story Points

Authored By
Charlotte
Feb 26 2019, 6:43 PM
Referenced Files
F28580687: transiiton.mov
Apr 4 2019, 4:53 PM
F28580511: Screenshot_20190404-183520.png
Apr 4 2019, 4:40 PM
F28580244: sys.png
Apr 4 2019, 4:18 PM
F28577894: Screenshot_20190404-131917.png
Apr 4 2019, 11:59 AM
F28577935: Screenshot_20190404-132602.png
Apr 4 2019, 11:59 AM
F28577889: eaf-03.png
Apr 4 2019, 11:59 AM
F28577937: Group.png
Apr 4 2019, 11:59 AM
F28577978: page-jump-after-load.mp4
Apr 4 2019, 11:59 AM

Description

Translate descriptions

👉 Visual changes to translate descriptions | T217170 on Zeplin

  • Replaced bidirectional with unidirectional icon to improve awareness of translation direction. Deemphasized it (54% black), since it’s a secondary action. Tapping the icon still swaps the language. These changes are based on these findings.
  • The presented card is always shown in the “From“ language.
  • The card itself is one tap target. A clear call to action (“Add German translation“) indicates users the task at hand.
  • The possibility to read the article has been removed in this view to not disrupt the edit flow.
  • To indicate users that a random card w/o title descriptions is shown, the dice, known from the “Randomizer“ feature is reused ((s. usability testing). The existing interface is perfect in this scenario.
  • A “Description published“ snackbar informs users about a successful contribution (Slide 25). The full screen “Description published“ dialog is only shown once after the first edit.
  • Once a description has been added, the card indicates it (“Translated by you“) and the familiar edit pencil icon is displayed. The card still is one tap target and tapping this card again takes users back to the “Add/translate description“ with the translation they previously added
  • The card feed lists all cards that users have interacted with (not only the one’s that have been edited) and should keep its “History“ per edit session.
  • Show more of article text based on the users screen height. The more content from the article, the better (more context for users). The minimum article text that should be shown is 3 lines.
  • To help users in deciding to add a description for a specific card, don’t show the placeholder image when there’s no “real“ article image. Instead, show more of the article text.

Translate description

👉 Visual changes to translate description | T217170 on Zeplin

  • Input field is active when users arrive on this screen (keyboard is visible).
  • Introducing a bottom element to easily access articles. Ideally, the bottom sheet displays more text than it does currently. This could be achieved by not showing preview images in the current implementation of the bottom sheet. Furthermore, it could be scrollable and show even more text.
  • Bottom sheet allows copy pasting of text (as it does now).
  • Tapping “Read article“ opens the article.
  • The article view should use a regular back button. Usability tests revealed (Slide 28), that the back button is disrupting the current edit flow. The visuals above show a way to solve the back button dilemma for the entire app.
    • “Open in a new tab“ is already covered with the tab feature on the article page that’s why it’s removed in the designs.
  • Once users start typing, the Continue button (tick) turns blue (#36c) to lead users to the next step (review screen)
  • Overall improved visual design.
  • Landscape: Check out the design on Zeplin. When there’s no article image, the available space should be used to display the extract.

RTL flow

Designs that illustrate the flow in RTL:

👉 RTL flow | T217170 on Zeplin

Event Timeline

Charlotte renamed this task from Visual changes to translate descriptions flow to Visual changes to translate descriptions.Feb 26 2019, 6:48 PM
cooltey updated the task description. (Show Details)

Hey @Charlotte, what do you think about this open point:

  • Question: Can we remove legal info and only show it on the “Review translation“ screen (the next step in the flow)?

Less distractions, more focus. Thanks for the feedback.

@schoenbaechler Yes, as long as we show the legal info/release before the user confirms their edit.

Yes, as long as we show the legal info/release before the user confirms their edit.

Great news for the UI @Charlotte, thanks!

Charlotte set the point value for this task to 5.

Added to the card’s description (derived from here T194327):

  • To help users in deciding to add a description for a specific card, don’t show the placeholder image when there’s no “real“ article image. Instead, show more of the article text.

FYI: @cooltey @Dbrant @Sharvaniharan @Charlotte

Added designs that illustrate the flow in RTL:

👉 RTL flow | T217170 on Zeplin

Might be of interest to @cooltey for the work in T217169 as well.

@schoenbaechler Can we limit the Rtl support to in-app components only, and not change the direction of the support toolbar? Which would mean the translation card would be rtl, but the title and arrow and overflow would still be inline with the system language.

Hey @Sharvaniharan, yes definitely. The top app bar would adapt to the system’s language. The mocks on Zeplin illustrate how the flow would look like when users have set the system language to Arabic.

Hey @Sharvaniharan, just so you know. I just reviewed the “Add description“ flow in T217169#5053622. Some of the comments there are also relevant for this task here.

Looks good @Sharvaniharan, a lot of things have been covered in T217169 already. Few things to optimize:

01 Move caret icon closer to label, see designs

ImplementationvsDesign
Screenshot_20190404-131917.png (2×1 px, 1 MB)
eaf-03.png (1×720 px, 531 KB)

02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.

BeforeAfter
Screenshot_20190404-132602.png (4×2 px, 1 MB)
Group.png (2×1 px, 422 KB)

03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):

@schoenbaechler We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list. For eg: This is how it looks with a really long named language:

sys.png (1×720 px, 304 KB)

01 Move caret icon closer to label, see designs

Unable to makeout the difference between the two 😂 . Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom? https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5c77d20a86d8b86292fd9750

02 Move plus icon and label ("Add German translation") 12dp lower (the values in sp are still a mystery to me). Please use the “After“ screenshot below (Pixel 3) to adjust the position accordingly.

BeforeAfter
Screenshot_20190404-132602.png (4×2 px, 1 MB)
Group.png (2×1 px, 422 KB)

@Sharvaniharan

We are using a system component for this, and it changes the space between the label and arrow according to the longest entry in the list.

Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?

Screenshot_20190404-183520.png (2×1 px, 87 KB)


Unable to makeout the difference between the two

You can see the difference when switching back and forth in the gallery on Phab, check out this screen recording that shows it.

Can I refer to zeplin and make it 9dp margin on top and 19dp on bottom?

Yeah, Zeplin is values are correct too.

Thanks for the clarifications @schoenbaechler
For point 03, we are not doing any particular transition here, it is just the system transition. The only improvement to the transition between the Activities that we can do is to fade-out first and fade-in next activity. I tried that, but I don't feel it looks all that good...Check it out.. Even assuming we do something about the keyboard coming up after the animation... looks unnecessarily dramatic.:

03 Related to transitioning from one screen to another (also affects T217169): is there a way to avoid the page jump at the top when arriving in the editing interface? (Observe “English description“ & “Beach of Portugal“ in the video below):

@schoenbaechler
My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]

Hmm interesting, I find it’s poorly designed with that huge gap. What component is Google Translate using here?

Screenshot_20190404-183520.png (2×1 px, 87 KB)

Thanks @Sharvaniharan!

For point 03, we are not doing any particular transition here, it is just the system transition.

The current page transition is fine, I was more referring to the jump after the transition (when you are on the next screen). It seems like “English description“ and “beach of Portugal“ are injected after the transition and this causes unpleasant movement (that is not necessary). Would it be possible to transition to the next screen as soon as all elements have been loaded?

My guess is that it is their custom component which is not exposed to us..[ I will look around if there is a function call to make it behave differently]

Cool! Thanks @Sharvaniharan! 👏

ABorbaWMF subscribed.

Looking good to me across a few devices and RTL languages on 2.7.278-beta-2019-04-05