Page MenuHomePhabricator
Create Task
Maniphest T217180

add phan to ci and local static code analysis
Closed, ResolvedPublic
Actions

Description

  • WMF is making a current version of the static php code analyzer phan available in ci[0]
  • we may want to add it to our extension as well [1]
  • However, the current config reports a lot of false positives (aka tiny code smells) that we may want to suppress
  • c.f. T217018: Upgrade Wikibase extension to use newer phan

[0]: https://lists.wikimedia.org/pipermail/wikitech-l/2019-February/091586.html
[1]: https://www.mediawiki.org/wiki/Continuous_integration/Tutorials/Add_phan_to_a_MediaWiki_extension

Details

SubjectRepoBranchLines +/-
Improve phan configmediawiki/extensions/WikibaseSchemamaster+21 -8
Add phan configmediawiki/extensions/WikibaseSchemamaster+17 -1
Enable phan for WikibaseSchemaintegration/configmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Michael created this task.Feb 26 2019, 6:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2019, 6:56 PM
Michael updated the task description. (Show Details)Feb 27 2019, 9:53 AM
gerritbot subscribed.Feb 27 2019, 11:00 AM

Change 493194 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Use phan in CI and pre commit hook

https://gerrit.wikimedia.org/r/493194

gerritbot added a project: Patch-For-Review.Feb 27 2019, 11:00 AM
gerritbot added a comment.Feb 27 2019, 12:06 PM

Change 493213 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[integration/config@master] Enable phan for WikibaseSchema

https://gerrit.wikimedia.org/r/493213

gerritbot added a comment.Feb 27 2019, 12:33 PM

Change 493194 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add phan config

https://gerrit.wikimedia.org/r/493194

gerritbot added a comment.Feb 28 2019, 2:24 PM

Change 493213 merged by jenkins-bot:
[integration/config@master] Enable phan for WikibaseSchema

https://gerrit.wikimedia.org/r/493213

Michael edited projects, added Shape Expressions Sprint 3; removed EntitySchema.Feb 28 2019, 3:00 PM
Michael moved this task from Backlog to Done on the Shape Expressions Sprint 3 board.
gerritbot added a comment.Mar 1 2019, 12:09 PM

Change 493673 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Improve phan config

https://gerrit.wikimedia.org/r/493673

Lucas_Werkmeister_WMDE moved this task from Done to Peer Review on the Shape Expressions Sprint 3 board.Mar 1 2019, 12:09 PM
gerritbot added a comment.Mar 1 2019, 12:33 PM

Change 493673 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Improve phan config

https://gerrit.wikimedia.org/r/493673

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 1 2019, 1:16 PM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Peer Review to Done on the Shape Expressions Sprint 3 board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL