Page MenuHomePhabricator
Create Task
Maniphest T217206

[wmf.19-regression] VE Flow pages misplaces toolbar
Closed, ResolvedPublic
Actions

Description

  1. Create a new post on Flow topic - save it.
  2. Open it for editing in VE mode - the toolbar will be misplaced.

Screen Shot 2019-02-26 at 2.38.12 PM.png (254×1 px, 32 KB)

Details

SubjectRepoBranchLines +/-
Make VisualEditor unwrap <section> tagsmediawiki/extensions/Flowwmf/1.33.0-wmf.19+2 -1
Make VisualEditor unwrap <section> tagsmediawiki/extensions/Flowmaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Feb 26 2019, 10:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 26 2019, 10:40 PM
Catrope added a comment.Feb 26 2019, 10:41 PM

Example topic where the top comment is a year old and the bottom comment was created today: https://test.wikipedia.org/wiki/Topic:U3m5gyhqh8i8doaw . The old comment behaves correctly but the new comment doesn't.

kostajh added a project: StructuredDiscussions.Feb 26 2019, 10:43 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptFeb 26 2019, 10:43 PM
kostajh subscribed.Feb 26 2019, 10:44 PM

Possibly caused by T209114: Store <head> (including Parsoid version number) for HTML Flow content

gerritbot subscribed.Feb 26 2019, 10:58 PM

Change 493125 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/Flow@master] Make VisualEditor unwrap <section> tags

https://gerrit.wikimedia.org/r/493125

gerritbot added a project: Patch-For-Review.Feb 26 2019, 10:58 PM
Catrope claimed this task.Feb 26 2019, 10:58 PM
Catrope edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
Catrope moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 27 2019, 2:10 AM

Change 493125 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Make VisualEditor unwrap <section> tags

https://gerrit.wikimedia.org/r/493125

Peachey88 added a project: Regression.Feb 27 2019, 8:44 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 27 2019, 3:24 PM
JTannerWMF moved this task from To Triage to External and Administrivia on the VisualEditor board.Feb 27 2019, 3:35 PM
gerritbot added a comment.Feb 27 2019, 3:53 PM

Change 493259 had a related patch set uploaded (by Kosta Harlan; owner: Catrope):
[mediawiki/extensions/Flow@wmf/1.33.0-wmf.19] Make VisualEditor unwrap <section> tags

https://gerrit.wikimedia.org/r/493259

gerritbot added a comment.Feb 27 2019, 5:44 PM

Change 493259 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.33.0-wmf.19] Make VisualEditor unwrap <section> tags

https://gerrit.wikimedia.org/r/493259

Stashbot subscribed.Feb 27 2019, 5:57 PM

Mentioned in SAL (#wikimedia-operations) [2019-02-27T17:57:18Z] <niharika29@deploy1001> Synchronized php-1.33.0-wmf.19/extensions/Flow/: Make VisualEditor unwrap <section> tags T217206 (duration: 01m 00s)

Etonkovidova closed this task as Resolved.Feb 28 2019, 12:13 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptFeb 28 2019, 12:13 AM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 11:03 AM
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.19; 2019-02-26); removed MW-1.33-notes (1.33.0-wmf.20; 2019-03-05).Mar 5 2019, 12:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL