| Pppery | |
| Feb 27 2019, 12:44 AM |
| F28606003: image.png | |
| Apr 10 2019, 10:34 PM |
When trying to edit a page transcluded in a cascade-protected page in the visual editor, instead of showing the typical "you can't do this" error, it lets you edit the page, showing the message that admins see when editing that page in the "Warnings" section.
The actual "you can't edit this" error messages doesn't occur until you try to publish your changes.
See Template:Citationneeded for an example.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • ppelberg | T217217 Visual editor and 2017 wikitext editor mishandle cascading protection | |||
| Resolved | • ppelberg | T53547 VisualEditor: Provide a "view VE" mode / disable editing for protected pages | |||
| Resolved | Esanders | T210142 Create a read-only mode for Visual Editor that allows inspection | |||
| Open | None | T311520 Respect isReadOnly in new template dialog sidebar |
The example I provided doesn't work anymore, because the page was protected, but the bug still exists
Note that there is an error message:
But in spite of that, the editor acts as if the page was editable (until you try to save changes). It should probably use the read-only mode we use for protected pages.
Change 511047 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Check if page is really editable and call #setReadOnly accordingly
Change 511047 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Check if page is really editable and call #setReadOnly accordingly