This is a little trickier than it seems at first. If we just check to see whether we have a value for it at all, we'll be hiding the fields on form re-display (for example, when an error occurs on the first form post). We'll have to implement a thing we've thought about for a while, which is to track in session WHERE we found each piece of data.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Ejegg | T215939 Edits to text on payments page | |||
| Resolved | Ejegg | T217254 Hide opt_in radio buttons when the choice has been provided on the query string |
Event Timeline
Comment Actions
Change 493334 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] WIP hide opt_in buttons when given on querystring
Comment Actions
Change 493334 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Hide opt_in buttons when given on querystring
Comment Actions
Change 494382 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@deployment] Hide opt_in buttons when given on querystring
Comment Actions
Change 494382 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@deployment] Hide opt_in buttons when given on querystring
Comment Actions
This is deployed - the radio buttons for the opt_in choices only appear when the donor is from a country where the field is required, and the donor has NOT indicated an opt_in choice on a banner or donatewiki.
However, the only countries where the field is required are IE and GB - @CCogdill_WMF and others, should we add more countries to that list?
Translations exist for the yes/no text and the explanation below in these languages:
ar
ast
de
en
fr
he
id
ja
mk
nb
pt-br
pt
roa-tara
uk
vi
zh-hans
zh-hant
Comment Actions
Yeah, good thinking! We should add all EU / UK countries to the list where
translations exist. Do you need an exhaustive list or is that directive
clear enough?
Comment Actions
Besides GB & IE for English, it looks like we can add Germany, France, Portugal, Ukraine, and North Macedonia. I guess Asturian (ast) is spoken in a part of Spain and Tarantino (roa-tara) in a part of Italy, but since es and it aren't on the list yet we shouldn't jump the gun.
Comment Actions
We have translations for Italian already--they ran on donate wiki in the
itIT email fundraiser. Not sure where the translation lives.
Comment Actions
Ah, cool, we can add those directly in the DonationInterface code, or via Translatewiki here: https://translatewiki.net/w/i.php?title=Special:Translate&group=ext-di-gc&language=it&filter=%21translated&optional=1&action=translate