Page MenuHomePhabricator

Mobile UI states edit saved when doing dummy edits
Open, Needs TriagePublic

Description

When filling phab report T217259, I noticed that when making a dummy edit, the edit saved dialog appears for dummy edits (see https://usercontent.irccloud-cdn.com/file/DA6a7AJT/7658CE80-E96C-41CB-9A36-5345D3CD03CC.MP4 for video of my edit)

Browser info:
iPhone 8 (Model MQ6H2B/A)
OS: iOS 12.1.4 (16D57)
Logged in: Y
Browser: Google Chrome (72.0.3626.101.)

Event Timeline

RhinosF1 created this task.Feb 27 2019, 5:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 27 2019, 5:22 PM
RhinosF1 updated the task description. (Show Details)Feb 27 2019, 5:22 PM
RhinosF1 updated the task description. (Show Details)

No edit saved box is shown in desktop for dummy edits

@Jdlrobson how's it Visual Editor?

By "dummy edit" do you mean adding whitespace?
I'm not entirely sure why its a problem to say that the save was a success even if no edit was registered in this case. Can you explain why this is a problem?

By "dummy edit" do you mean adding whitespace?
I'm not entirely sure why its a problem to say that the save was a success even if no edit was registered in this case. Can you explain why this is a problem?

See the video attached, but yes. It just threw me as to why it said saved when it wasn't when looking for the diff in the linked task.

@Jdlrobson how's it Visual Editor?

VisualEditor is the project board that the editing team to manage their work. The VisualEditor team mostly maintain the MobileFrontend editor. Since this question is around behaviour that's a decision I believe that should be made by them.

@Jdlrobson how's it Visual Editor?

VisualEditor is the project board that the editing team to manage their work. The VisualEditor team mostly maintain the MobileFrontend editor. Since this question is around behaviour that's a decision I believe that should be made by them.

Ah, I didn't realise that. I assumed visual editor was like the desktop visual editor tool.

marcella moved this task from To Triage to Freezer on the VisualEditor board.Mar 12 2019, 3:48 PM