Page MenuHomePhabricator

Create feed card for suggested edits and update iconography
Closed, ResolvedPublic5 Estimated Story Points

Authored By
scblr
Feb 28 2019, 8:24 PM
Referenced Files
F28887218: Group.png
May 1 2019, 4:13 PM
F28786449: Screenshot_20190427-120537.png
Apr 26 2019, 10:10 AM
F28786377: Screenshot_20190427-120333.png
Apr 26 2019, 10:10 AM
F28786042: Screenshot_20190427-115149.png
Apr 26 2019, 10:10 AM
F28596092: margin_no_image.png
Apr 8 2019, 7:50 PM
F28595749: no_image.png
Apr 8 2019, 6:14 PM
F28478054: customization_strings.png
Mar 27 2019, 4:01 PM

Description

Feed cards

👉 Create feed card for editor tasks and update iconography | T217373 on Zeplin

There are two types of editor task feed cards in V1:

  • “Add description“ feed cards, shown once “Add descriptions“ task has been unlocked
  • “Translate description“ feed cards, shown once “Translate descriptions“ task been unlocked
  • Details about unlocking can be found in this task: T217369

Conceptual details:

  • Explore feed card logic:
    • Editor tasks has not been unlocked yet: No “Editor tasks“ feed cards are shown.
    • Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.
    • Add and translate descriptions have been unlocked (50 non-reverted edits): Alternating daily suggestions for “Add descriptions“ and “Translate descriptions“ are shown in the feed. There’s always only one “Editor tasks“ card shown for a particular day.
  • Tapping one of these cards leads users directly to the Add description or Translate description flow respectively
  • When users are accessing editor tasks features for the first time, the onboarding dialog is shown. After tapping “Get started“, users are taken to the card they’ve tapped on in the explore feed in Add/translate descriptions.
  • Customize the feed: Add option for “Editor tasks“ once it’s unlocked (see Zeplin)
  • Display the article’s extract when there’s no article image is available in the “Suggested edits“ feed card.

Iconography

To emphasize the new terminology (“Editor tasks“ instead of “App editor tasks“), the icon for the feature has been updated to represent these changes. In order to make this change happen the “Customize the feed“ iconography has been changed to a tune icon. Please check out the Zeplin screen to view the changes.

Event Timeline

scblr updated the task description. (Show Details)

Added details about the feed card’s logic to the task’s description:

  • Explore feed card logic:
    • Editor tasks has not been unlocked yet: No “Editor tasks“ feed cards are shown.
    • Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.
    • Add and translate descriptions have been unlocked (50 non-reverted edits): Alternating daily suggestions for “Add descriptions“ and “Translate descriptions“ are shown in the feed. There’s always only one “Editor tasks“ card shown for a particular day.
  • Customize the feed: Add option for “Editor tasks“ once it’s unlocked (see Zeplin)

Feedback appreciated @Dbrant @Charlotte @cooltey @Sharvaniharan. Thanks!

Charlotte set the point value for this task to 5.

As just discussed with @Sharvaniharan: we’re going to display the article’s extract when there’s no article image available in the “Suggested edits“ feed card.

Could I get strings for the title and description for the feed card in customize screen:

customization_strings.png (800×480 px, 66 KB)

@Sharvaniharan, ideally this is solved with a single setting, as described in T219462. In case it’s not feasible for V1, here are the strings:

Suggested edits: Add descriptions
Suggestions to add article descriptions to Wikipedia

Suggested edits: Translate descriptions
Suggestions to translate article descriptions on Wikipedia

Added it to Suggested edits | Copy master doc as well.

@schoenbaechler Could you please let me know the margins when there is no image?

margin_no_image.png (1×720 px, 133 KB)

Thank you @schoenbaechler!

When there are no translation cards, should we show add description cards everyday or only alternate days?

Add descriptions has been unlocked (3 non-reverted edits): Daily suggestions for “Add descriptions“ are shown in the feed.

Looks like the answer is daily... :) please confirm.

Thanks @Sharvaniharan, nice to see suggested edits in the feed!

I found these discrepancies from the proposed concept:

01) Users should stay within the “Add/translate descriptions“ workflow when coming from the “Explore feed“. Currently, the behavior that’s implemented in the Alpha is that users return to the “Explore feed“. The user journey should be:

  1. Users taps a “Suggested edit“ card in the “Explore feed“
  2. Users add/translate a description
  3. Users are presented with a new card within the Add/translate descriptions view

Screenshot_20190427-120333.png (2×1 px, 304 KB)

02) Change iconography of “Suggested edits“ and “Customize the feed“ as listed in this task’s description:

To emphasize the new terminology (“Editor tasks“ instead of “App editor tasks“), the icon for the feature has been updated to represent these changes. In order to make this change happen the “Customize the feed“ iconography has been changed to a tune icon. Please check out the Zeplin screen to view the changes.

03) Use backgroundImage from Android theme guidelines for icon in the card’s title:

Screenshot_20190427-115149.png (2×1 px, 913 KB)

04) I could not double check the feed’s behavior (show alternate cards for Add/Translate descriptions) since the developer setting suggestedEditsTranslateDescriptionsUnlocked does not seem to have an effect on the feed. Could you add that dev setting so I can test it, please?

Screenshot_20190427-120537.png (2×1 px, 204 KB)

01) Users should stay within the “Add/translate descriptions“ workflow when coming from the “Explore feed“. Currently, the behavior that’s implemented in the Alpha is that users return to the “Explore feed“. The user journey should be:

  1. Users taps a “Suggested edit“ card in the “Explore feed“
  2. Users add/translate a description
  3. Users are presented with a new card within the Add/translate descriptions view

@schoenbaechler I just want to discuss this change as to how important it is, given that the card gets refreshed anyway when the user scrolls up/down far enough, and we have new suggestions for each day.. if you feel this still needs to be done, will do it.

Hey @Sharvaniharan, thanks for asking. The part of *staying in the edit flow* is key for these Explore feed cards. They work as advertisement for “Suggested edits“. It’s not about that one edit, we want readers to become active and long time editors. Leading them back to the Explore feed disrupts the editing flow, the effort it takes to tap another feed card that’s further up or down is too big.

Thank you @schoenbaechler will do it

scblr renamed this task from Create feed card for editor tasks and update iconography to Create feed card for suggested edits and update iconography.May 1 2019, 4:08 PM

Hey @Sharvaniharan, just noticed that I haven’t mentioned this in my previous comment.

Could you change the icons for “Customize the feed“ and “Suggested edits“, as defined on Zeplin?

Group.png (2×1 px, 601 KB)

https://zpl.io/29OKdqp

You mentioned it @schoenbaechler ... its done :)

ABorbaWMF subscribed.

Looks good to me on 2.7.50282-alpha-2019-05-29 and a couple previous builds :)